You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/09 12:48:39 UTC
[GitHub] [kafka] vitojeng opened a new pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
vitojeng opened a new pull request #10657:
URL: https://github.com/apache/kafka/pull/10657
follow-up #8200
KAFKA-5876's PR break into multiple parts, this PR is part 4 - apply InvalidStateStorePartitionException
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #10657:
URL: https://github.com/apache/kafka/pull/10657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-837549700
Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-835912874
@ableegoldman Please take a look :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231
Hey @vitojeng , was this the final PR for KIP-216? If not is the next one available yet? No rush, just want to make sure you haven't been waiting on reviews this whole time 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman edited a comment on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
ableegoldman edited a comment on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849145231
Hey @vitojeng , was this the final PR for KIP-216? If not is the next one available yet? No rush, just want to make sure you haven't been waiting on reviews this whole time 🙂
edit: I copied over the list of exceptions on the KIP to the ticket description and marked those I could find PRs for as done. Please let me know if I missed any (to answer my question above, it seems there are three exceptions/PRs remaining, is that correct?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849170302
@ableegoldman Thanks for your concern, KIP-216 still in progress. 🙂
It's really busy in the last two weeks, some bad things continue to happen in Taiwan.
I will stick to it until KIP-216 is completed. 💪
> Please let me know if I missed any (to answer my question above, it seems there are three exceptions/PRs remaining, is that correct?)
Yes, you are right. The three exceptions are the most important part in KIP-216, IMO.
I wish to submit the next PR in next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vitojeng commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
vitojeng commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-837571301
@ableegoldman Thanks. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10657: KAFKA-5876: Apply InvalidStateStorePartitionException for Interactive Queries
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-849182031
No worries! Take care of yourself first, KIP-216 can wait for you 🙂 I just wanted to check in and mostly, make sure you don't need anything from my end. I'll keep an eye out for the next parts whenever they're ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org