You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ZJaffee <gi...@git.apache.org> on 2015/07/17 04:56:03 UTC
[GitHub] incubator-brooklyn pull request: Minor improvement on an ajax call
GitHub user ZJaffee opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/752
Minor improvement on an ajax call
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ZJaffee/incubator-brooklyn master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit 81cb0bacb7af129eb4c5932336a75b0850141d62
Author: Zach Jaffee <zi...@case.edu>
Date: 2015-07-17T02:49:28Z
Minor improvement on an ajax call
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Minor improvement on an ajax call
Posted by ZJaffee <gi...@git.apache.org>.
Github user ZJaffee closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/752
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Minor improvement on an ajax call
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/752#issuecomment-122251783
@ZJaffee Could you describe the improvement here? From what I can see you've swapped fail/done for success/error. Personally I prefer the former. Is there good reason to use the latter?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Minor improvement on an ajax call
Posted by hzbarcea <gi...@git.apache.org>.
Github user hzbarcea commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/752#issuecomment-122243353
This PR breaks the build. Tested locally as well and got the error below. Could you please take a look again?
```
[ERROR] Caused by: com.gargoylesoftware.htmlunit.ScriptException: missing } after property list (http://localhost:55424/src/js/view/policy-new.js#66)
[ERROR] at com.gargoylesoftware.htmlunit.javascript.JavaScriptEngine$HtmlUnitContextAction.run(JavaScriptEngine.java:684)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Minor improvement on an ajax call
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/752#issuecomment-124167583
@ZJaffee On top of @sjcorbett comment, I would rather use the ` jqXHR.fail()` and `jqXHR.done()` (which can be chained) instead of the configuration keys `error` and `success`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---