You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "funky-eyes (via GitHub)" <gi...@apache.org> on 2024/02/18 10:14:39 UTC

[PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

funky-eyes opened a new pull request, #6348:
URL: https://github.com/apache/incubator-seata/pull/6348

   
   
   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have registered the PR [changes](../changes).
   
   ### Ⅰ. Describe what this PR did
   
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6348:
URL: https://github.com/apache/incubator-seata/pull/6348#discussion_r2190292502


##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/exec/UpdateExecutor.java:
##########
@@ -97,20 +98,30 @@ protected String buildBeforeImageSQL(TableMeta tableMeta, ArrayList<List<Object>
 
     @Override
     protected TableRecords afterImage(TableRecords beforeImage) throws SQLException {
-        TableMeta tmeta = getTableMeta();
         if (beforeImage == null || beforeImage.size() == 0) {
             return TableRecords.empty(getTableMeta());
         }
-        String selectSQL = buildAfterImageSQL(tmeta, beforeImage);
+        TableMeta tmeta = getTableMeta();
         PreparedStatement pst = null;
         ResultSet rs = null;
-        try {
-            pst = statementProxy.getConnection().prepareStatement(selectSQL);
-            SqlGenerateUtils.setParamForPk(beforeImage.pkRows(), getTableMeta().getPrimaryKeyOnlyName(), pst);
-            rs = pst.executeQuery();
-            return TableRecords.buildRecords(tmeta, rs);
-        } finally {
-            IOUtil.close(rs, pst);
+        SQLUpdateRecognizer recognizer = (SQLUpdateRecognizer) sqlRecognizer;
+        List<String> whereColumns = recognizer.getWhereColumns();
+        boolean contain =
+                statementProxy.getConnection().getTransactionIsolation() == Connection.TRANSACTION_REPEATABLE_READ
+                        || tmeta.containsPK(whereColumns);
+        if (contain) {
+            String selectSQL = buildAfterImageSQL(tmeta, beforeImage);
+            try {
+                pst = statementProxy.getConnection().prepareStatement(selectSQL);
+                SqlGenerateUtils.setParamForPk(
+                        beforeImage.pkRows(), getTableMeta().getPrimaryKeyOnlyName(), pst);
+                rs = pst.executeQuery();
+                return TableRecords.buildRecords(tmeta, rs);
+            } finally {
+                IOUtil.close(rs, pst);
+            }
+        } else {
+            return beforeImage();

Review Comment:
   This attempts to call `beforeImage()` but `beforeImage` is the method parameter (a `TableRecords`), causing a compile error. It should return the parameter directly: `return beforeImage;`
   ```suggestion
               return beforeImage;
   ```



##########
sqlparser/seata-sqlparser-druid/src/main/java/org/apache/seata/sqlparser/druid/sqlserver/SqlServerUpdateRecognizer.java:
##########
@@ -202,6 +202,12 @@ public String getOrderByCondition(ParametersHolder parametersHolder, ArrayList<L
         return null;
     }
 
+    @Override
+    public List<String> getWhereColumns() {

Review Comment:
   [nitpick] The `getWhereColumns` override is duplicated across every dialect-specific recognizer. Consider moving this logic into a shared abstract base class or default method to reduce code duplication.



##########
sqlparser/seata-sqlparser-druid/src/main/java/org/apache/seata/sqlparser/druid/sqlserver/SqlServerUpdateRecognizer.java:
##########
@@ -202,6 +202,12 @@ public String getOrderByCondition(ParametersHolder parametersHolder, ArrayList<L
         return null;
     }
 
+    @Override
+    public List<String> getWhereColumns() {
+        SQLExpr where = ast.getWhere();
+        return ColumnUtils.delEscape(super.getWhereColumns(where), getDbType());

Review Comment:
   If `ast.getWhere()` is null (no WHERE clause), this will NPE. Add a null check: e.g. `if (where == null) return Collections.emptyList();` before calling `super.getWhereColumns(where)`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #6348:
URL: https://github.com/apache/incubator-seata/pull/6348#issuecomment-1951570458

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   Attention: `28 lines` in your changes are missing coverage. Please review.
   > Comparison is base [(`f80a0fa`)](https://app.codecov.io/gh/apache/incubator-seata/commit/f80a0fadb66fa4e5f2a3feae135a7163ae73b70e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 51.94% compared to head [(`914b8e1`)](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 51.97%.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/6348/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #6348      +/-   ##
   ============================================
   + Coverage     51.94%   51.97%   +0.02%     
   - Complexity     5185     5202      +17     
   ============================================
     Files           921      921              
     Lines         32181    32247      +66     
     Branches       3876     3890      +14     
   ============================================
   + Hits          16716    16759      +43     
   - Misses        13829    13850      +21     
   - Partials       1636     1638       +2     
   ```
   
   
   | [Files](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...pache/seata/rm/datasource/exec/UpdateExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS9leGVjL1VwZGF0ZUV4ZWN1dG9yLmphdmE=) | `85.71% <100.00%> (+1.62%)` | :arrow_up: |
   | [...a/sqlparser/druid/mysql/MySQLUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL215c3FsL015U1FMVXBkYXRlUmVjb2duaXplci5qYXZh) | `63.00% <100.00%> (+0.75%)` | :arrow_up: |
   | [...e/seata/sqlparser/druid/dm/DmUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL2RtL0RtVXBkYXRlUmVjb2duaXplci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...sqlparser/druid/oracle/OracleUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL29yYWNsZS9PcmFjbGVVcGRhdGVSZWNvZ25pemVyLmphdmE=) | `7.01% <0.00%> (-0.26%)` | :arrow_down: |
   | [...r/druid/postgresql/PostgresqlUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL3Bvc3RncmVzcWwvUG9zdGdyZXNxbFVwZGF0ZVJlY29nbml6ZXIuamF2YQ==) | `7.01% <0.00%> (-0.26%)` | :arrow_down: |
   | [...ser/druid/sqlserver/SqlServerUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL3NxbHNlcnZlci9TcWxTZXJ2ZXJVcGRhdGVSZWNvZ25pemVyLmphdmE=) | `70.83% <0.00%> (-2.03%)` | :arrow_down: |
   | [...g/apache/seata/sqlparser/druid/BaseRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1kcnVpZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2RydWlkL0Jhc2VSZWNvZ25pemVyLmphdmE=) | `85.33% <90.90%> (+4.38%)` | :arrow_up: |
   | [...ta/rm/datasource/exec/AbstractDMLBaseExecutor.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS9leGVjL0Fic3RyYWN0RE1MQmFzZUV4ZWN1dG9yLmphdmE=) | `48.33% <16.66%> (-3.52%)` | :arrow_down: |
   | [...parser/antlr/mysql/AntlrMySQLUpdateRecognizer.java](https://app.codecov.io/gh/apache/incubator-seata/pull/6348?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3FscGFyc2VyL3NlYXRhLXNxbHBhcnNlci1hbnRsci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvc3FscGFyc2VyL2FudGxyL215c3FsL0FudGxyTXlTUUxVcGRhdGVSZWNvZ25pemVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   
   ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/6348/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6348:
URL: https://github.com/apache/incubator-seata/pull/6348#discussion_r2190315352


##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/exec/UpdateExecutor.java:
##########
@@ -97,20 +98,30 @@ protected String buildBeforeImageSQL(TableMeta tableMeta, ArrayList<List<Object>
 
     @Override
     protected TableRecords afterImage(TableRecords beforeImage) throws SQLException {
-        TableMeta tmeta = getTableMeta();
         if (beforeImage == null || beforeImage.size() == 0) {
             return TableRecords.empty(getTableMeta());
         }
-        String selectSQL = buildAfterImageSQL(tmeta, beforeImage);
+        TableMeta tmeta = getTableMeta();
         PreparedStatement pst = null;
         ResultSet rs = null;
-        try {
-            pst = statementProxy.getConnection().prepareStatement(selectSQL);
-            SqlGenerateUtils.setParamForPk(beforeImage.pkRows(), getTableMeta().getPrimaryKeyOnlyName(), pst);
-            rs = pst.executeQuery();
-            return TableRecords.buildRecords(tmeta, rs);
-        } finally {
-            IOUtil.close(rs, pst);
+        SQLUpdateRecognizer recognizer = (SQLUpdateRecognizer) sqlRecognizer;
+        List<String> whereColumns = recognizer.getWhereColumns();
+        boolean contain =
+                statementProxy.getConnection().getTransactionIsolation() == Connection.TRANSACTION_REPEATABLE_READ
+                        || tmeta.containsPK(whereColumns);
+        if (contain) {
+            String selectSQL = buildAfterImageSQL(tmeta, beforeImage);
+            try {
+                pst = statementProxy.getConnection().prepareStatement(selectSQL);
+                SqlGenerateUtils.setParamForPk(
+                        beforeImage.pkRows(), getTableMeta().getPrimaryKeyOnlyName(), pst);
+                rs = pst.executeQuery();
+                return TableRecords.buildRecords(tmeta, rs);
+            } finally {
+                IOUtil.close(rs, pst);
+            }
+        } else {
+            return beforeImage();

Review Comment:
   Calling beforeImage() will re-execute the SQL for beforeImage and generate a new beforeImage. If you directly return beforeImage, it will be the old image, which is not the expected behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #6348:
URL: https://github.com/apache/incubator-seata/pull/6348#discussion_r2190331473


##########
sqlparser/seata-sqlparser-druid/src/main/java/org/apache/seata/sqlparser/druid/BaseRecognizer.java:
##########
@@ -149,4 +157,62 @@ public boolean visit(SQLInsertStatement x) {
         getAst().accept(visitor);
         return true;
     }
+
+    public List<String> getWhereColumns(SQLExpr sqlExpr) {
+        if (sqlExpr == null) {
+            return Collections.emptyList();
+        }
+        // single condition
+        if (sqlExpr instanceof SQLBinaryOpExpr) {
+            return getWhereColumns(Collections.singletonList(sqlExpr));
+        } else {
+            // multiple conditions
+            return getWhereColumns(sqlExpr.getChildren());
+        }
+    }
+
+    public List<String> getWhereColumns(List<SQLObject> list) {
+        if (CollectionUtils.isNotEmpty(list)) {
+            List<String> columns = new ArrayList<>(list.size());
+            for (SQLObject sqlObject : list) {
+                if (sqlObject instanceof SQLIdentifierExpr) {
+                    columns.add(((SQLIdentifierExpr) sqlObject).getName());
+                } else {
+                    getWhereColumns(sqlObject, columns);
+                }
+            }
+            return columns;
+        }
+        return Collections.emptyList();
+    }
+
+    public void getWhereColumns(SQLObject sqlExpr, List<String> list) {
+        if (sqlExpr instanceof SQLBinaryOpExpr) {
+            SQLExpr left = ((SQLBinaryOpExpr) sqlExpr).getLeft();
+            getWhereColumn(left, list);
+            SQLExpr right = ((SQLBinaryOpExpr) sqlExpr).getRight();
+            getWhereColumn(right, list);
+        }
+    }
+
+    public void getWhereColumn(SQLExpr left, List<String> list) {
+        if (left instanceof SQLBetweenExpr) {
+            SQLExpr expr = ((SQLBetweenExpr) left).getTestExpr();
+            if (expr instanceof SQLIdentifierExpr) {
+                list.add(((SQLIdentifierExpr) expr).getName());
+            }
+            if (expr instanceof SQLPropertyExpr) {
+                list.add(((SQLPropertyExpr) expr).getName());
+            }
+        } else if (left instanceof SQLIdentifierExpr) {
+            list.add(((SQLIdentifierExpr) left).getName());

Review Comment:
   Currently `getWhereColumn` handles `SQLIdentifierExpr` and `SQLBetweenExpr` but ignores direct `SQLPropertyExpr` (qualified columns) in equality or other expressions. Add an `else if (left instanceof SQLPropertyExpr)` branch to capture those column names as well.
   ```suggestion
               list.add(((SQLIdentifierExpr) left).getName());
           } else if (left instanceof SQLPropertyExpr) {
               list.add(((SQLPropertyExpr) left).getName());
   ```



##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/exec/AbstractDMLBaseExecutor.java:
##########
@@ -98,6 +100,16 @@ protected T executeAutoCommitFalse(Object[] args) throws Exception {
         try {
             TableRecords beforeImage = beforeImage();
             T result = statementCallback.execute(statementProxy.getTargetStatement(), args);
+            int updateCount = statementProxy.getUpdateCount();
+            if (updateCount > 0) {
+                if (SQLType.UPDATE == sqlRecognizer.getSQLType()) {
+                    if (updateCount > beforeImage.size()) {
+                        String errorMsg =
+                                "Before image size is not equaled to after image size, probably because you use read committed, please retry transaction.";

Review Comment:
   The check only throws when `updateCount` is greater than `beforeImage.size()`. To ensure full consistency, consider enforcing exact equality (`updateCount != beforeImage.size()`) so mismatches in either direction are caught.
   ```suggestion
                       if (updateCount != beforeImage.size()) {
                           String errorMsg =
                                   "Before image size is not equal to after image size, possibly due to read committed isolation level or other issues. Please retry the transaction.";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix: the problem that the number of mirrors before and after may be inconsistent [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes commented on code in PR #6348:
URL: https://github.com/apache/incubator-seata/pull/6348#discussion_r2190342670


##########
sqlparser/seata-sqlparser-druid/src/main/java/org/apache/seata/sqlparser/druid/BaseRecognizer.java:
##########
@@ -149,4 +157,62 @@ public boolean visit(SQLInsertStatement x) {
         getAst().accept(visitor);
         return true;
     }
+
+    public List<String> getWhereColumns(SQLExpr sqlExpr) {
+        if (sqlExpr == null) {
+            return Collections.emptyList();
+        }
+        // single condition
+        if (sqlExpr instanceof SQLBinaryOpExpr) {
+            return getWhereColumns(Collections.singletonList(sqlExpr));
+        } else {
+            // multiple conditions
+            return getWhereColumns(sqlExpr.getChildren());
+        }
+    }
+
+    public List<String> getWhereColumns(List<SQLObject> list) {
+        if (CollectionUtils.isNotEmpty(list)) {
+            List<String> columns = new ArrayList<>(list.size());
+            for (SQLObject sqlObject : list) {
+                if (sqlObject instanceof SQLIdentifierExpr) {
+                    columns.add(((SQLIdentifierExpr) sqlObject).getName());
+                } else {
+                    getWhereColumns(sqlObject, columns);
+                }
+            }
+            return columns;
+        }
+        return Collections.emptyList();
+    }
+
+    public void getWhereColumns(SQLObject sqlExpr, List<String> list) {
+        if (sqlExpr instanceof SQLBinaryOpExpr) {
+            SQLExpr left = ((SQLBinaryOpExpr) sqlExpr).getLeft();
+            getWhereColumn(left, list);
+            SQLExpr right = ((SQLBinaryOpExpr) sqlExpr).getRight();
+            getWhereColumn(right, list);
+        }
+    }
+
+    public void getWhereColumn(SQLExpr left, List<String> list) {
+        if (left instanceof SQLBetweenExpr) {
+            SQLExpr expr = ((SQLBetweenExpr) left).getTestExpr();
+            if (expr instanceof SQLIdentifierExpr) {
+                list.add(((SQLIdentifierExpr) expr).getName());
+            }
+            if (expr instanceof SQLPropertyExpr) {
+                list.add(((SQLPropertyExpr) expr).getName());
+            }
+        } else if (left instanceof SQLIdentifierExpr) {
+            list.add(((SQLIdentifierExpr) left).getName());

Review Comment:
   Currently, JSON columns are not supported, so we won't consider adding this condition directly for now.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org