You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/09 16:10:25 UTC
[GitHub] [hudi] xushiyan opened a new pull request, #5273: [HUDI-3837] Fix license and rat check settings
xushiyan opened a new pull request, #5273:
URL: https://github.com/apache/hudi/pull/5273
- add missing licenses
- fix CI setting to run rat plugin
- fix deploy script to include integ test modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan merged pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #5273:
URL: https://github.com/apache/hudi/pull/5273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5273:
URL: https://github.com/apache/hudi/pull/5273#discussion_r846660586
##########
pom.xml:
##########
@@ -1375,7 +1376,8 @@
<id>integration-tests</id>
<activation>
<property>
- <name>integration-tests</name>
+ <name>deployArtifacts</name>
+ <value>true</value>
Review Comment:
So, to build integ test bundle (after this patch), what should one execute?
previously it was
```
mvn package -DskipTests -Dintegration-tests
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5273:
URL: https://github.com/apache/hudi/pull/5273#issuecomment-1094077660
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7946",
"triggerID" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d50b7d7b66ed9feb66d3169e075aa14b9fe002f5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7946)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5273:
URL: https://github.com/apache/hudi/pull/5273#issuecomment-1094077136
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d50b7d7b66ed9feb66d3169e075aa14b9fe002f5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on a diff in pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on code in PR #5273:
URL: https://github.com/apache/hudi/pull/5273#discussion_r846662951
##########
pom.xml:
##########
@@ -1375,7 +1376,8 @@
<id>integration-tests</id>
<activation>
<property>
- <name>integration-tests</name>
+ <name>deployArtifacts</name>
+ <value>true</value>
Review Comment:
got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5273:
URL: https://github.com/apache/hudi/pull/5273#issuecomment-1094091029
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7946",
"triggerID" : "d50b7d7b66ed9feb66d3169e075aa14b9fe002f5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d50b7d7b66ed9feb66d3169e075aa14b9fe002f5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=7946)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5273:
URL: https://github.com/apache/hudi/pull/5273#discussion_r846653463
##########
pom.xml:
##########
@@ -1375,7 +1376,8 @@
<id>integration-tests</id>
<activation>
<property>
- <name>integration-tests</name>
+ <name>deployArtifacts</name>
+ <value>true</value>
Review Comment:
deploy script set this prop so that integ tests modules can be included
##########
scripts/release/deploy_staging_jars.sh:
##########
@@ -73,6 +73,6 @@ fi
for v in "${ALL_VERSION_OPTS[@]}"
do
echo "Deploying to repository.apache.org with version option ${v}"
- COMMON_OPTIONS="${v} -Prelease -DskipTests -DretryFailedDeploymentCount=10 -DdeployArtifacts=true"
+ COMMON_OPTIONS="${v} -DdeployArtifacts=true -DskipTests -DretryFailedDeploymentCount=10"
Review Comment:
deployArtifacts=true activates both release and integration-tests profiles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #5273: [HUDI-3837] Fix license and rat check settings
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #5273:
URL: https://github.com/apache/hudi/pull/5273#discussion_r846661662
##########
pom.xml:
##########
@@ -1375,7 +1376,8 @@
<id>integration-tests</id>
<activation>
<property>
- <name>integration-tests</name>
+ <name>deployArtifacts</name>
+ <value>true</value>
Review Comment:
it's always used as `mvn package -Pintegration-tests`. this is just an activation property, which wasn't used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org