Re: [I] CometCaseConversionBase gates compat inside convert() instead of getSupportLevel [datafusion-comet]

["dwsmith1983 (via GitHub)" <gi...@apache.org>]

dwsmith1983 commented on issue #4467:
URL: https://github.com/apache/datafusion-comet/issues/4467#issuecomment-5637068891

   #4721 (46b58411d) reworked this. `CometCaseConversionBase` in spark/src/main/scala/org/apache/comet/serde/strings.scala now overrides `getSupportLevel` and the support level is `Compatible` with a `NativeOptIn` pointing at `spark.comet.caseConversion.enabled`; `convert` no longer gates or returns `None`, it only chooses between the native kernel (opt-in) and the codegen dispatcher (default), so `lower`/`upper` never fall back to Spark and EXPLAIN, the COMET-INFO hint and the generated docs all describe the same thing. The three consequences listed here (bypassed `allowIncompatible` machinery, EXPLAIN/doc disagreement, asymmetry with `initcap`) no longer apply, and `initcap`, `lower` and `upper` are all documented as Hybrid in docs/source/user-guide/latest/expressions.md. Suggest closing.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org