You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2021/05/17 17:49:24 UTC

[GitHub] [tika] tballison commented on a change in pull request #441: fix for TIKA-3400 contributed by kamaci

tballison commented on a change in pull request #441:
URL: https://github.com/apache/tika/pull/441#discussion_r633735419



##########
File path: tika-eval/tika-eval-core/src/main/java/org/apache/tika/eval/core/tokens/URLEmailNormalizingFilterFactory.java
##########
@@ -69,11 +69,10 @@ public boolean incrementToken() throws IOException {
                 return false;
             }
             //== is actually substantially faster than .equals(String)
-            if (typeAtt.type() == UAX29URLEmailTokenizer.TOKEN_TYPES[UAX29URLEmailTokenizer.URL]) {
+            if (typeAtt.type().equals(UAX29URLEmailTokenizer.TOKEN_TYPES[UAX29URLEmailTokenizer.URL])) {

Review comment:
       This was done out of a notional sense of efficiency. I'm not sure we need to change it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org