You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/19 03:48:12 UTC
[GitHub] [pulsar] liudezhi2098 opened a new pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
liudezhi2098 opened a new pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826
Master Issue: #13755
## Motivation
Unregistering namespace rg-3/rg-0 will affect the subsequent course of action
## Documentation
- [x] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#issuecomment-1016395154
> Thanks for fixing the problem @liudezhi2098 Merging since this test is extremely flaky and blocks CI. The Thread.sleep isn't optimal, but that can be improved in a separate PR.
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787411872
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -84,6 +84,7 @@ public long computeLocalQuota(long confUsage, long myUsage, long[] allUsages) {
this.rgservice = new ResourceGroupService(pulsar, TimeUnit.SECONDS, transportMgr, dummyQuotaCalc);
this.prepareRGs();
+ Thread.sleep(2000);
Review comment:
Can we use Awaitibility to check if the namespace has been registered? So that we can make the test more stable, 2 seconds might also not be stable enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari merged pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
lhotari merged pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787505344
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -164,22 +165,22 @@ public void run() {
sentNumBytes += mesg.length;
sentNumMsgs++;
log.debug("Producer={}, sent msg-ix={}, msgId={}", producerId, ix, msgId);
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while sending {}-th time: ex={}",
- producerId, ix, p.getMessage());
+ log.error("Producer={} got exception while sending {}-th time: ex={}",
+ producerId, ix, e.getMessage());
}
}
try {
producer.flush();
producer.close();
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while closing producer: ex={}",
- producerId, p.getMessage());
+ log.error("Producer={} got exception while closing producer: ex={}",
+ producerId, e.getMessage());
}
- log.debug("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
+ log.info("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
Review comment:
ok, now I see other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787523591
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -84,6 +84,7 @@ public long computeLocalQuota(long confUsage, long myUsage, long[] allUsages) {
this.rgservice = new ResourceGroupService(pulsar, TimeUnit.SECONDS, transportMgr, dummyQuotaCalc);
this.prepareRGs();
+ Thread.sleep(2000);
Review comment:
@codelipenghui Although the Thread.sleep isn't optimal, I'd like to merge this PR since the test is extremely flaky. @liudezhi2098 please attempt the suggested improvement in a new PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#issuecomment-1016113201
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
lhotari commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787390218
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -164,22 +165,22 @@ public void run() {
sentNumBytes += mesg.length;
sentNumMsgs++;
log.debug("Producer={}, sent msg-ix={}, msgId={}", producerId, ix, msgId);
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while sending {}-th time: ex={}",
- producerId, ix, p.getMessage());
+ log.error("Producer={} got exception while sending {}-th time: ex={}",
+ producerId, ix, e.getMessage());
}
}
try {
producer.flush();
producer.close();
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while closing producer: ex={}",
- producerId, p.getMessage());
+ log.error("Producer={} got exception while closing producer: ex={}",
+ producerId, e.getMessage());
}
- log.debug("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
+ log.info("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
Review comment:
These changes seem to only change the logging level. @liudezhi2098 Do you think that this makes a difference and resolves the flakiness in the test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787394320
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -164,22 +165,22 @@ public void run() {
sentNumBytes += mesg.length;
sentNumMsgs++;
log.debug("Producer={}, sent msg-ix={}, msgId={}", producerId, ix, msgId);
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while sending {}-th time: ex={}",
- producerId, ix, p.getMessage());
+ log.error("Producer={} got exception while sending {}-th time: ex={}",
+ producerId, ix, e.getMessage());
}
}
try {
producer.flush();
producer.close();
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while closing producer: ex={}",
- producerId, p.getMessage());
+ log.error("Producer={} got exception while closing producer: ex={}",
+ producerId, e.getMessage());
}
- log.debug("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
+ log.info("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
Review comment:
Mainly to add a wait during setup()，logging level just a matter of better positioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liudezhi2098 commented on a change in pull request #13826: [Flaky-test] RGUsageMTAggrWaitForAllMsgsTest. testMTProduceConsumeRGUsageNonPersistentTopicNamesDifferentTenant
Posted by GitBox <gi...@apache.org>.
liudezhi2098 commented on a change in pull request #13826:
URL: https://github.com/apache/pulsar/pull/13826#discussion_r787394320
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/resourcegroup/RGUsageMTAggrWaitForAllMsgsTest.java
##########
@@ -164,22 +165,22 @@ public void run() {
sentNumBytes += mesg.length;
sentNumMsgs++;
log.debug("Producer={}, sent msg-ix={}, msgId={}", producerId, ix, msgId);
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while sending {}-th time: ex={}",
- producerId, ix, p.getMessage());
+ log.error("Producer={} got exception while sending {}-th time: ex={}",
+ producerId, ix, e.getMessage());
}
}
try {
producer.flush();
producer.close();
- } catch (PulsarClientException p) {
+ } catch (PulsarClientException e) {
numExceptions++;
- log.info("Producer={} got exception while closing producer: ex={}",
- producerId, p.getMessage());
+ log.error("Producer={} got exception while closing producer: ex={}",
+ producerId, e.getMessage());
}
- log.debug("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
+ log.info("Producer={} done with topic={}; got {} exceptions", producerId, myProduceTopic, numExceptions);
Review comment:
Mainly to add a wait during setup()，aviod unregistering namspace.
logging level just a matter of better positioning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org