You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "FrNecas (via GitHub)" <gi...@apache.org> on 2023/08/24 15:52:46 UTC
[GitHub] [arrow] FrNecas commented on a diff in pull request #37341: GH-21815: [JS] Add support for Duration type
FrNecas commented on code in PR #37341:
URL: https://github.com/apache/arrow/pull/37341#discussion_r1304548424
##########
docs/source/status.rst:
##########
@@ -44,19 +44,19 @@ Data Types
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| Float32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
-| Decimal128 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | |
+| Decimal128 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
-| Decimal256 | ✓ | ✓ | ✓ | | ✓ | ✓ | ✓ | |
+| Decimal256 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| Date32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| Time32/64 | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
| Timestamp | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
-| Duration | ✓ | ✓ | ✓ | | | ✓ | ✓ | |
+| Duration | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | |
+-------------------+-------+-------+-------+------------+-------+-------+-------+-------+
-| Interval | ✓ | ✓ | ✓ | | | ✓ | ✓ | |
+| Interval | ✓ | ✓ | ✓ | ✓ | | ✓ | ✓ | |
Review Comment:
Good catch, only the first two are supported. Are you fine with marking it as implemented with a footnote mentioning that `MONTH_DAY_NANO` is not supported yet? I feel like seeing that it's completely unimplemented may confuse some people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org