[GitHub] [ignite] nyshubin commented on a change in pull request #8503: IGNITE-13680 maxSwappiness declared as int in suggestions

[GitBox <gi...@apache.org>]

nyshubin commented on a change in pull request #8503:
URL: https://github.com/apache/ignite/pull/8503#discussion_r549232015



##########
File path: modules/core/src/main/java/org/apache/ignite/internal/suggestions/OsConfigurationSuggestions.java
##########
@@ -60,12 +60,12 @@
     public static synchronized List<String> getSuggestions() {
         List<String> suggestions = new ArrayList<>();
 
-        if (U.isRedHat()) {
-            String value;
-            String expected = "500";
+        if (U.isLinux()) {
+            String val;
+            String exp = "500";
 
-            boolean dwcParamFlag = (value = readVmParam(DIRTY_WRITEBACK_CENTISECS)) != null && !value.equals(expected);
-            boolean decParamFlag = (value = readVmParam(DIRTY_EXPIRE_CENTISECS)) != null && !value.equals(expected);
+            boolean dwcParamFlag = (val = readVmParam(DIRTY_WRITEBACK_CENTISECS)) != null && !val.equals(exp);

Review comment:
       Cast exp and val to int and replaced .equals comparison with val > exp (500)
   The gridgain guide suggests: As a solution, you can try changing the page flushing interval from the default 30 seconds to 5 seconds




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org