You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/05/04 21:15:55 UTC
[jira] Created: (LUCENE-2444) move contrib/analyzers to
modules/analysis
move contrib/analyzers to modules/analysis
------------------------------------------
Key: LUCENE-2444
URL: https://issues.apache.org/jira/browse/LUCENE-2444
Project: Lucene - Java
Issue Type: Task
Components: Build
Affects Versions: 4.0
Reporter: Robert Muir
Attachments: LUCENE-2444.patch
This is a patch to move contrib/analyzers under modules/analyzers
We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864345#action_12864345 ]
Robert Muir commented on LUCENE-2444:
-------------------------------------
Committed revision 941308.
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2444:
--------------------------------
Attachment: LUCENE-2444.patch
Here are the instructions:
{noformat}
mkdir -p modules/analysis
svn add modules
svn move lucene/contrib/analyzers/* modules/analysis
patch -p0 < ../LUCENE-2444.patch
{noformat}
All tests pass.
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864390#action_12864390 ]
Robert Muir commented on LUCENE-2444:
-------------------------------------
Committed LUCENE-2444_boilerplate.patch revision 941369.
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch, LUCENE-2444_boilerplate.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864299#action_12864299 ]
Robert Muir commented on LUCENE-2444:
-------------------------------------
If no one objects, i'd like to commit this first patch today to move the code in SVN.
This is just a step. Then we can keep the issue open and discuss what/if-any additional
things should be moved to the module:
* LICENSE/NOTICE? I know i have been polluting the lucene one heavily from analyzer poaching.
* CHANGES? I think a module having its own would make sense
* ... other things?
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2444:
--------------------------------
Attachment: LUCENE-2444.patch
i applied this patch to a checkout, then removed contrib/analyzers completely.
there was a problem, the contrib-uptodate macro assumes contrib/*
So this patch fixes the problem by adding a module-uptodate macro, you can test it
by following the same instructions, but additionally doing 'rm -rf contrib/analyzers'.
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2444:
--------------------------------
Attachment: LUCENE-2444_boilerplate.patch
Attached is a "boilerplate" patch for the analysis module.
It contains:
* README: describing filenames etc
* LICENSE
* NOTICE: describing all poached analyzers licenses, etc
* CHANGES: describing all 4.0-only analyzers changes.
I yanked these CHANGES from core/contrib's CHANGES file...
Additionally i cleaned up the core NOTICE.txt
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch, LUCENE-2444_boilerplate.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Resolved: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir resolved LUCENE-2444.
---------------------------------
Assignee: Robert Muir
Resolution: Fixed
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Assignee: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch, LUCENE-2444_boilerplate.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864385#action_12864385 ]
Robert Muir commented on LUCENE-2444:
-------------------------------------
ok if no one objects i'll commit this boilerplate stuff soon.
we can try to improve the language etc later but its a start.
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch, LUCENE-2444.patch, LUCENE-2444_boilerplate.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864294#action_12864294 ]
Yonik Seeley commented on LUCENE-2444:
--------------------------------------
+1, looks good!
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2444) move contrib/analyzers to
modules/analysis
Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864310#action_12864310 ]
Michael McCandless commented on LUCENE-2444:
--------------------------------------------
This looks great Robert!
> move contrib/analyzers to modules/analysis
> ------------------------------------------
>
> Key: LUCENE-2444
> URL: https://issues.apache.org/jira/browse/LUCENE-2444
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Affects Versions: 4.0
> Reporter: Robert Muir
> Attachments: LUCENE-2444.patch
>
>
> This is a patch to move contrib/analyzers under modules/analyzers
> We can then continue consolidating (LUCENE-2413)... in truth this will sorta be
> an ongoing thing anyway, as we try to distance indexing from analysis, etc
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org