You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by be...@apache.org on 2009/04/12 01:49:50 UTC
svn commit: r764263 - in
/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth:
OAuthRequest.java OAuthResponseParams.java
Author: beaton
Date: Sat Apr 11 23:49:50 2009
New Revision: 764263
URL: http://svn.apache.org/viewvc?rev=764263&view=rev
Log:
Turn down log level when unauthenticated users try to use OAuth, gadget
code can handle that error just fine.
Modified:
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java?rev=764263&r1=764262&r2=764263&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthRequest.java Sat Apr 11 23:49:50 2009
@@ -193,7 +193,11 @@
response = fetchWithRetry();
} catch (OAuthRequestException e) {
// No data for us.
- responseParams.logDetailedWarning("OAuth fetch fatal error", e);
+ if (OAuthError.UNAUTHENTICATED.toString().equals(responseParams.getError())) {
+ responseParams.logDetailedInfo("Unauthenticated OAuth fetch", e);
+ } else {
+ responseParams.logDetailedWarning("OAuth fetch fatal error", e);
+ }
responseParams.setSendTraceToClient(true);
if (response == null) {
response = new HttpResponseBuilder()
Modified: incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java
URL: http://svn.apache.org/viewvc/incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java?rev=764263&r1=764262&r2=764263&view=diff
==============================================================================
--- incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java (original)
+++ incubator/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/OAuthResponseParams.java Sat Apr 11 23:49:50 2009
@@ -120,6 +120,10 @@
public void logDetailedWarning(String note, Throwable cause) {
logger.log(Level.WARNING, note + '\n' + getDetails(), cause);
}
+
+ public void logDetailedInfo(String note, Throwable cause) {
+ logger.log(Level.INFO, note + '\n' + getDetails(), cause);
+ }
/**
* Add a request/response pair to our trace of actions associated with this request.