You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "SHIN HWEI TAN (Issue Comment Edited) (JIRA)" <xa...@xml.apache.org> on 2012/04/13 03:25:17 UTC
[jira] [Issue Comment Edited] (XALANJ-2556) Inconsistent Javadoc
comment and code for execute(TransformerImpl) in
org.apache.xalan.templates.ElemFallback
[ https://issues.apache.org/jira/browse/XALANJ-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253039#comment-13253039 ]
SHIN HWEI TAN edited comment on XALANJ-2556 at 4/13/12 1:25 AM:
----------------------------------------------------------------
The Javadoc comments reported above are only referring to "@param transformer non-null reference to the the current transform-time state." for the method execute(TransformerImpl) in the templates/ElemFallback.java file because the method is empty.
was (Author: shinhwei):
The Javadoc comments reported above are only referring to "@param transformer non-null reference to the the current transform-time state." for the method execute(TransformerImpl transformer) in the templates/ElemFallback.java file because the method is empty.
> Inconsistent Javadoc comment and code for execute(TransformerImpl) in org.apache.xalan.templates.ElemFallback
> -------------------------------------------------------------------------------------------------------------
>
> Key: XALANJ-2556
> URL: https://issues.apache.org/jira/browse/XALANJ-2556
> Project: XalanJ2
> Issue Type: Bug
> Security Level: No security risk; visible to anyone(Ordinary problems in Xalan projects. Anybody can view the issue.)
> Affects Versions: 2.7.1, 2.7
> Environment: Platform Independent
> Reporter: SHIN HWEI TAN
> Labels: javadoc
> Original Estimate: 0.05h
> Remaining Estimate: 0.05h
>
> The Javadoc comment below states that the parameter transformer is a "non-null reference to the the current transform-time state.":
> /**
> ...
> * @param transformer non-null reference to the the current transform-time state.
> ...
> */
> public void execute(TransformerImpl transformer) throws TransformerException
> However, the method does not check the parameter for "null". It executes normally without throwing any exception when called with a null transformer.
> Suggested Fixes:
> 1. Add parameter check for "null"
> or
> 2. Remove "non-null" from @param.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org