You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (JIRA)" <ji...@apache.org> on 2012/04/27 07:20:13 UTC
[jira] [Resolved] (SOLR-3402) Parse Version outside of Analysis
Factories
[ https://issues.apache.org/jira/browse/SOLR-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved SOLR-3402.
------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Fixed in trunk.
> Parse Version outside of Analysis Factories
> -------------------------------------------
>
> Key: SOLR-3402
> URL: https://issues.apache.org/jira/browse/SOLR-3402
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: SOLR-3402.patch, SOLR-3402.patch, SOLR-3402.patch
>
>
> Currently the Lucene Version value is put into the Map that is passed to the {{init}} method of Analysis factories. During the initialization, the value is parsed and validated. In situations where the Core wide value is used, it is converted to a String only for it to be parsed again. I think we can improve this, reduce the amount of parsing, and provide a cleaner separation of concerns.
> Instead the value should be parsed externally and then passed into the Factory. The Factory would be responsible for checking that it was given a Version value. Any additional validation such as general guidelines about Versions to use, would then fall on code that passed in the Version to the Factory (namely, FieldPluginLoader).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org