You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2020/03/06 18:36:33 UTC
[GitHub] [drill] vvysotskyi opened a new pull request #2015: DRILL-7628: Fix
Mongo tests broken after the fix for DRILL-7547
vvysotskyi opened a new pull request #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
URL: https://github.com/apache/drill/pull/2015
# [DRILL-7628](https://issues.apache.org/jira/browse/DRILL-7628): Fix Mongo tests broken after the fix for DRILL-7547
## Description
Fixed test suite name in pom file, since all mongo tests were skipped during tests run because of this issue. Made changes to create mongo user for tests using a conf file. Added missed `TestMongoStoragePluginUsesCredentialsStore` to the test suite.
## Documentation
NA
## Testing
Ran all tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] asfgit closed pull request #2015: DRILL-7628: Fix Mongo
tests broken after the fix for DRILL-7547
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
URL: https://github.com/apache/drill/pull/2015
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #2015: DRILL-7628: Fix
Mongo tests broken after the fix for DRILL-7547
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
URL: https://github.com/apache/drill/pull/2015#issuecomment-597139833
+1, LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva commented on issue #2015: DRILL-7628: Fix
Mongo tests broken after the fix for DRILL-7547
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva commented on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
URL: https://github.com/apache/drill/pull/2015#issuecomment-596991728
@vvysotskyi I think maybe we'll get rid of this test suite logic?
We can make all Mongo tests extend `MongoTestBase.class`, annotate `MongoTestBase.class` with `@Category({MongoStorageTest.class})` so we can skip or include Mongo tests and that's it, so suite logic will be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [drill] arina-ielchiieva removed a comment on issue #2015:
DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
Posted by GitBox <gi...@apache.org>.
arina-ielchiieva removed a comment on issue #2015: DRILL-7628: Fix Mongo tests broken after the fix for DRILL-7547
URL: https://github.com/apache/drill/pull/2015#issuecomment-596991728
@vvysotskyi I think maybe we'll get rid of this test suite logic?
We can make all Mongo tests extend `MongoTestBase.class`, annotate `MongoTestBase.class` with `@Category({MongoStorageTest.class})` so we can skip or include Mongo tests and that's it, so suite logic will be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services