You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hugegraph.apache.org by "imbajin (via GitHub)" <gi...@apache.org> on 2026/07/12 09:52:02 UTC
[PR] refactor(vermeer): cross-compile Docker binaries [hugegraph-computer]
imbajin opened a new pull request, #353:
URL: https://github.com/apache/hugegraph-computer/pull/353
## Summary
- run the Vermeer Go builder on the native BuildKit platform
- cross-compile the final CGO-disabled binary with TARGETOS and TARGETARCH
- cache Go modules and compiler artifacts
- separate Go and UI dependency downloads from source copies
## Why
The current multi-platform build runs the arm64 Go build through QEMU. Vermeer uses CGO_ENABLED=0, so BuildKit can build natively and cross-compile the target binary without emulation.
The companion cache and read-only branch validation workflow is included in hugegraph/actions#22.
## Verification
- confirmed CGO_ENABLED=0 and target architecture is passed explicitly to go build
- verified Docker COPY paths against the vermeer build context and .dockerignore
- git diff --check passed
- independent cross-repository review passed
The local Docker daemon and Go toolchain were unavailable. The companion Actions workflow should run the final amd64/arm64 branch validation before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refactor(vermeer): cross-compile Docker binaries [hugegraph-computer]
Posted by "imbajin (via GitHub)" <gi...@apache.org>.
imbajin commented on code in PR #353:
URL: https://github.com/apache/hugegraph-computer/pull/353#discussion_r3566417863
##########
vermeer/Dockerfile:
##########
@@ -14,14 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-FROM golang:1.23-alpine AS builder
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS builder
+ARG TARGETOS
Review Comment:
Addressed in 9c4bcb6. TARGETOS and TARGETARCH are now declared immediately before the final go build, so apk installation, module/UI downloads, and asset generation remain target-neutral and share cache across platforms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refactor(vermeer): cross-compile Docker binaries [hugegraph-computer]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #353:
URL: https://github.com/apache/hugegraph-computer/pull/353#discussion_r3566237180
##########
vermeer/Dockerfile:
##########
@@ -14,14 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-FROM golang:1.23-alpine AS builder
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS builder
+ARG TARGETOS
Review Comment:
**Medium: Scope target arguments to the compilation step**
`vermeer/Dockerfile:18`
**Evidence**
- `TARGETOS` and `TARGETARCH` precede `apk add`, module download, UI download, and asset generation. The validation log executed each step separately for amd64 and arm64 (#14/#15, #20/#21, #26/#27, #30/#31).
**Impact**
- Network-heavy downloads and asset generation scale with the number of target platforms, defeating target-neutral layer sharing.
**Requested fix**
- Move both `ARG` declarations immediately before the final `go build`, or put target-neutral preparation in a separate base stage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refactor(vermeer): cross-compile Docker binaries [hugegraph-computer]
Posted by "VGalaxies (via GitHub)" <gi...@apache.org>.
VGalaxies commented on code in PR #353:
URL: https://github.com/apache/hugegraph-computer/pull/353#discussion_r3566237180
##########
vermeer/Dockerfile:
##########
@@ -14,14 +14,27 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-FROM golang:1.23-alpine AS builder
+FROM --platform=$BUILDPLATFORM golang:1.23-alpine AS builder
+ARG TARGETOS
Review Comment:
### ⚠️ Scope target arguments to the compilation step
`TARGETOS` and `TARGETARCH` precede `apk add`, module download, UI download, and asset generation. The validation log executed each step separately for amd64 and arm64 (`#14`/`#15`, `#20`/`#21`, `#26`/`#27`, `#30`/`#31`).
> [!WARNING]
> Network-heavy downloads and asset generation scale with the number of target platforms, defeating target-neutral layer sharing.
🛠️ **Suggested change:** Move both `ARG` declarations immediately before the final `go build`, or put target-neutral preparation in a separate base stage.
---
<sub>🤖 Codex review · **GPT-5.6 Sol** · effort: **max**</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org
Re: [PR] refactor(vermeer): cross-compile Docker binaries [hugegraph-computer]
Posted by "zyxxoo (via GitHub)" <gi...@apache.org>.
zyxxoo merged PR #353:
URL: https://github.com/apache/hugegraph-computer/pull/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@hugegraph.apache.org
For additional commands, e-mail: issues-help@hugegraph.apache.org