You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "cyphercodes (via GitHub)" <gi...@apache.org> on 2026/03/29 03:54:24 UTC
[PR] fix(ace-editor): fix cursor misalignment in markdown editor [superset]
cyphercodes opened a new pull request, #38928:
URL: https://github.com/apache/superset/pull/38928
### Problem
When editing Markdown on a dashboard, the cursor becomes misaligned with the text. This makes it difficult to edit content as the cursor appears in the wrong position relative to the actual text.
### Solution
Added explicit font-family styling to Ace editor's content elements (.ace_content and .ace_text-layer) to ensure consistent font rendering. The cursor misalignment was caused by font-family mismatches between the editor's internal measurements and the actual rendered text.
### Changes
- Added font-family: ${editorFontFamily} !important to .ace_editor .ace_content
- Added font-family: ${editorFontFamily} !important to .ace_editor .ace_text-layer
### Testing
This fix ensures that the font-family used for text measurement matches the font-family used for rendering, which resolves the cursor position calculation issues in Ace editor.
Fixes #38850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ace-editor): fix cursor misalignment in markdown editor [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38928:
URL: https://github.com/apache/superset/pull/38928#issuecomment-4156764033
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/38928?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 64.58%. Comparing base ([`dbc25dc`](https://app.codecov.io/gh/apache/superset/commit/dbc25dc5557cb1584b636840ff52f34c85628439?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`d2a10af`](https://app.codecov.io/gh/apache/superset/commit/d2a10af29ac10c403ca7bc113c573d0caec1a845?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38928 +/- ##
=======================================
Coverage 64.58% 64.58%
=======================================
Files 2536 2536
Lines 130811 130811
Branches 30346 30346
=======================================
Hits 84486 84486
Misses 44856 44856
Partials 1469 1469
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/38928/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/38928/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.83% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/38928?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ace-editor): fix cursor misalignment in markdown editor [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #38928:
URL: https://github.com/apache/superset/pull/38928#issuecomment-4156651071
Thanks for the PR... I'll try to find some time to test (but please, beat me to it, anyone!)
Did you check to see if this also fixes issues (if indeed they exist) in SQL Lab, ad hoc metrics/SQL in the Explore Chart builder, etc)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ace-editor): fix cursor misalignment in markdown editor [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch merged PR #38928:
URL: https://github.com/apache/superset/pull/38928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(ace-editor): fix cursor misalignment in markdown editor [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #38928:
URL: https://github.com/apache/superset/pull/38928#issuecomment-4149364751
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org