You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2014/03/12 20:17:33 UTC

[1/2] git commit: calling styleDefault and styleLightContent should only affect text color

Repository: cordova-plugins
Updated Branches:
  refs/heads/master 2c4701802 -> e638d0828


calling styleDefault and styleLightContent should only affect text color


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugins/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugins/commit/47d55a03
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugins/tree/47d55a03
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugins/diff/47d55a03

Branch: refs/heads/master
Commit: 47d55a03840fb99961af554459a84e3eede211be
Parents: 2c47018
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Wed Mar 12 12:00:11 2014 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Wed Mar 12 12:00:11 2014 -0700

----------------------------------------------------------------------
 statusbar/src/wp/StatusBar.cs | 5 -----
 1 file changed, 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/47d55a03/statusbar/src/wp/StatusBar.cs
----------------------------------------------------------------------
diff --git a/statusbar/src/wp/StatusBar.cs b/statusbar/src/wp/StatusBar.cs
index c20f680..ec83ca8 100644
--- a/statusbar/src/wp/StatusBar.cs
+++ b/statusbar/src/wp/StatusBar.cs
@@ -79,10 +79,7 @@ namespace WPCordovaClassLib.Cordova.Commands
         {    //exec(null, null, "StatusBar", "styleDefault", []);
             Deployment.Current.Dispatcher.BeginInvoke(() =>
             {
-                SystemTray.BackgroundColor = Colors.White;
                 SystemTray.ForegroundColor = Colors.Black;
-                SystemTray.Opacity = 1.0d;
-
             });
         }
 
@@ -91,9 +88,7 @@ namespace WPCordovaClassLib.Cordova.Commands
             
             Deployment.Current.Dispatcher.BeginInvoke(() =>
             {
-                SystemTray.BackgroundColor = Colors.Black;
                 SystemTray.ForegroundColor = Colors.White;
-                SystemTray.Opacity = 1.0d;
             });
         }
 


[2/2] git commit: cleaned up js, removed unused requires, removed unused 'new' object function and defined directly

Posted by pu...@apache.org.
cleaned up js, removed unused requires, removed unused 'new' object function and defined directly


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugins/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugins/commit/e638d082
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugins/tree/e638d082
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugins/diff/e638d082

Branch: refs/heads/master
Commit: e638d0828a73f4755c08ac90ac1ed57679a8d27f
Parents: 47d55a0
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Wed Mar 12 12:17:04 2014 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Wed Mar 12 12:17:04 2014 -0700

----------------------------------------------------------------------
 statusbar/www/statusbar.js | 140 ++++++++++++++++++++--------------------
 1 file changed, 69 insertions(+), 71 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugins/blob/e638d082/statusbar/www/statusbar.js
----------------------------------------------------------------------
diff --git a/statusbar/www/statusbar.js b/statusbar/www/statusbar.js
index dc456a9..6f4e879 100644
--- a/statusbar/www/statusbar.js
+++ b/statusbar/www/statusbar.js
@@ -1,83 +1,81 @@
 /*
-     *
-     * Licensed to the Apache Software Foundation (ASF) under one
-     * or more contributor license agreements.  See the NOTICE file
-     * distributed with this work for additional information
-     * regarding copyright ownership.  The ASF licenses this file
-     * to you under the Apache License, Version 2.0 (the
-     * "License"); you may not use this file except in compliance
-     * with the License.  You may obtain a copy of the License at
-     *
-     *   http://www.apache.org/licenses/LICENSE-2.0
-     *
-     * Unless required by applicable law or agreed to in writing,
-     * software distributed under the License is distributed on an
-     * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-     * KIND, either express or implied.  See the License for the
-     * specific language governing permissions and limitations
-     * under the License.
-     *
-    */
-
-    var argscheck = require('cordova/argscheck'),
-        utils = require('cordova/utils'),
-        exec = require('cordova/exec');
-
-    var namedColors = {
-        "black": "#000000",
-        "darkGray": "#A9A9A9",
-        "lightGray": "#D3D3D3",
-        "white": "#FFFFFF",
-        "gray": "#808080",
-        "red": "#FF0000",
-        "green": "#00FF00",
-        "blue": "#0000FF",
-        "cyan": "#00FFFF",
-        "yellow": "#FFFF00",
-        "magenta": "#FF00FF",
-        "orange": "##FFA500",
-        "purple": "#800080",
-        "brown": "#A52A2A"
-    };
-
-    // prime it
-    
-    exec(function (res) {
-        StatusBar.isVisible = res;
-    }, null, "StatusBar", "_ready", []);
-
-    var StatusBar = function () {
-    };
-
-    StatusBar.overlaysWebView = function (doOverlay) {
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+*/
+
+var exec = require('cordova/exec');
+
+var namedColors = {
+    "black": "#000000",
+    "darkGray": "#A9A9A9",
+    "lightGray": "#D3D3D3",
+    "white": "#FFFFFF",
+    "gray": "#808080",
+    "red": "#FF0000",
+    "green": "#00FF00",
+    "blue": "#0000FF",
+    "cyan": "#00FFFF",
+    "yellow": "#FFFF00",
+    "magenta": "#FF00FF",
+    "orange": "##FFA500",
+    "purple": "#800080",
+    "brown": "#A52A2A"
+};
+
+// prime it
+exec(function (res) {
+    StatusBar.isVisible = res;
+}, null, "StatusBar", "_ready", []);
+
+var StatusBar = {
+
+    isVisible: true,
+
+    overlaysWebView: function (doOverlay) {
         exec(null, null, "StatusBar", "overlaysWebView", [doOverlay]);
-    };
+    },
 
-    StatusBar.styleDefault = function () {
-        // dark text on a light background
+    styleDefault: function () {
+        // dark text ( to be used on a light background )
         exec(null, null, "StatusBar", "styleDefault", []);
-    };
+    },
 
-    StatusBar.styleLightContent = function () {
-        // light text on a dark background
+    styleLightContent: function () {
+        // light text ( to be used on a dark background )
         exec(null, null, "StatusBar", "styleLightContent", []);
-    };
+    },
 
-    StatusBar.styleBlackTranslucent = function () {
+    styleBlackTranslucent: function () {
         // #88000000 ? Apple says to use lightContent instead
         exec(null, null, "StatusBar", "styleBlackTranslucent", []);
-    };
+    },
 
-    StatusBar.styleBlackOpaque = function () {
+    styleBlackOpaque: function () {
         // #FF000000 ? Apple says to use lightContent instead
         exec(null, null, "StatusBar", "styleBlackOpaque", []);
-    };
+    },
 
-    StatusBar.backgroundColorByName = function (colorname) {
+    backgroundColorByName: function (colorname) {
         return StatusBar.backgroundColorByHexString(namedColors[colorname]);
-    }
+    },
 
-    StatusBar.backgroundColorByHexString = function (hexString) {
+    backgroundColorByHexString: function (hexString) {
         if (hexString.indexOf("#") < 0) {
             hexString = "#" + hexString;
         }
@@ -88,18 +86,18 @@
         }
 
         exec(null, null, "StatusBar", "backgroundColorByHexString", [hexString]);
-    }
+    },
 
-    StatusBar.hide = function () {
+    hide: function () {
         exec(null, null, "StatusBar", "hide", []);
         StatusBar.isVisible = false;
-    }
+    },
 
-    StatusBar.show = function () {
+    show: function () {
         exec(null, null, "StatusBar", "show", []);
         StatusBar.isVisible = true;
     }
 
-    StatusBar.isVisible = true;
+};
 
-    module.exports = StatusBar;
+module.exports = StatusBar;