You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "LinSimon-901101 (via GitHub)" <gi...@apache.org> on 2026/09/29 03:32:12 UTC
[I] Add integer boundary coverage to in-memory cache pruning tests [datafusion-comet]
LinSimon-901101 opened a new issue, #6378:
URL: https://github.com/apache/datafusion-comet/issues/6378
### What is the problem the feature request solves?
### What is the problem the feature request solves?
Follow-up to #6262.
The predicates in `CometInMemoryCachePruningSuite` do not directly test integer min/max boundaries. The selected IDs in `id IN (1, 9, 49)` fall inside their batches, while `n IS NULL` checks null counts. As a result, an integer upper bound that is one too small can go undetected by this suite.
### Describe the potential solution
Add `n = 5` to the shared predicate list. In the existing fixture, the matching batch contains only `n = 5`, so this predicate exercises both its lower and upper bounds.
Verify all three writer paths: native Arrow, Spark columnar, and row input. Keep the independent expected-result and pruning assertions. With the current fixture, the predicate should return IDs 20–23 and retain one four-row batch.
### Additional context
Suggested during review of #6262:
https://github.com/apache/datafusion-comet/pull/6262#discussion_r4128060318
Related original issue: #6203.
### Describe the potential solution
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add integer boundary coverage to in-memory cache pruning tests [datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao closed issue #6378: Add integer boundary coverage to in-memory cache pruning tests
URL: https://github.com/apache/datafusion-comet/issues/6378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Add integer boundary coverage to in-memory cache pruning tests [datafusion-comet]
Posted by "LinSimon-901101 (via GitHub)" <gi...@apache.org>.
LinSimon-901101 commented on issue #6378:
URL: https://github.com/apache/datafusion-comet/issues/6378#issuecomment-5883105387
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org