[GitHub] [trafficserver] zwoop commented on a change in pull request #7674: Reduce overhead incurred by enabling debug output.

[GitBox <gi...@apache.org>]

zwoop commented on a change in pull request #7674:
URL: https://github.com/apache/trafficserver/pull/7674#discussion_r670819145



##########
File path: include/ts/ts.h
##########
@@ -2165,11 +2165,40 @@ tsapi void TSDebug(const char *tag, const char *format_str, ...) TS_PRINTFLIKE(2
     @param ... Format arguments.
  */
 tsapi void TSDebugSpecific(int debug_flag, const char *tag, const char *format_str, ...) TS_PRINTFLIKE(3, 4);
-extern int diags_on_for_plugins;
+extern int diags_on_for_plugins; /* Do not use directly. */

Review comment:
       I feel reasonably strongly that for 10.0.0, we should:
   
   1. Mark TSDebug() deprecated here (such that it gives compiler warnings)
   2. Change all plugins in the core to use TSDbg() (to avoid warnings from # 1.

##########
File path: include/tscore/Diags.h
##########
@@ -56,7 +56,21 @@
 #endif
 #endif
 
-extern inkcoreapi Diags *diags;
+class DiagsPtr

Review comment:
       I think for core use of Dbg(), we should assert, or at least warn when there is a duplication of a control (i.e. two or more versions of a debug label).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org