You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/03 21:13:46 UTC
[GitHub] [arrow-rs] carols10cents opened a new pull request #1000: Minimize features of indexmap and chrono
carols10cents opened a new pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000
# Which issue does this PR close?
Closes #999.
# Rationale for this change
In the case of chrono, making sure these crates aren't turning on a feature name that's deprecated and will be removed eventually, and that they're turning on the minimal number of features actually used to minimize the features projects depending on these crates will be forced to turn on.
In the case of indexmap, by explicitly enabling the "std" feature since arrow isn't targetting no_std environments, this might save a bit of build time done by the indexmap crate at build time to try to automatically detect whether the target has std available or not.
# What changes are included in this PR?
Adjustments to the feature sets of chrono and indexmap
# Are there any user-facing changes?
If projects depending on arrow/parquet are making use of the coincidence that arrow/parquet turns on chrono features, this might mean they have to turn on the features themselves, but that would be a bug in that project's use of chrono.
I can't imagine the indexmap change would affect anyone except for maybe building slightly faster :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on a change in pull request #1000: Minimize features of indexmap and chrono
Posted by GitBox <gi...@apache.org>.
alamb commented on a change in pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000#discussion_r762437095
##########
File path: arrow/Cargo.toml
##########
@@ -40,15 +40,15 @@ path = "src/lib.rs"
serde = { version = "1.0", features = ["rc"] }
serde_derive = "1.0"
serde_json = { version = "1.0", features = ["preserve_order"] }
-indexmap = "1.6"
+indexmap = { version = "1.6", features = ["std"] }
Review comment:
I know some arrow users target `wasm` which has some strange semantics related to std, however, we have a test for compiling with a `wasm` target, and those seem to have passed on this PR:
https://github.com/apache/arrow-rs/runs/4413147281?check_suite_focus=true
fyi @roee88
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1000: Minimize features of indexmap and chrono
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000#issuecomment-986045417
Thanks @carols10cents
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb merged pull request #1000: Minimize features of indexmap and chrono
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] alamb commented on pull request #1000: Minimize features of indexmap and chrono
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1000:
URL: https://github.com/apache/arrow-rs/pull/1000#issuecomment-998068515
This didn't backport (cherry-pick) cleanly; Not sure why but I don't plan to spend any time figuring it out and instead will wait for arrow 7.0.0 release. If anyone else needs this sooner feel free to get a PR up to `active_release`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org