You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2023/02/22 11:16:23 UTC

[GitHub] [superset] kgabryje commented on pull request #23141: [WIP] feat(dashboard): Add cross filter from context menu

kgabryje commented on PR #23141:
URL: https://github.com/apache/superset/pull/23141#issuecomment-1439842994

   > The divider should not appear if only one item is in the menu
   > 
   > ![Screenshot 2023-02-22 at 12 01 59](https://user-images.githubusercontent.com/60598000/220601824-07fd6c5b-5d4c-4e1e-bdd5-7032fe4c6890.png)
   
   Nice catch!
   
   > The context menu is appearing also when clicking on labels. I think we should not allow that. It is correctly ignoring it but I believe a better UX would be to just disable it for labels. Wdyt?
   > 
   > ![Screenshot 2023-02-22 at 12 06 41](https://user-images.githubusercontent.com/60598000/220602857-ca90c7b8-25a1-4579-bc44-8c5e9ae38ec4.png)
   
   Yeah you're right... Though it might be difficult to work around as the "fallback" context menu listener is attached to chart container, not the plugin itself. I'll see what I can do


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org