[GitHub] [incubator-daffodil] rsteinberger commented on a change in pull request #414: Throw SDE in the case of inputValueCalc containing checkConstraints(.)

[GitBox <gi...@apache.org>]

rsteinberger commented on a change in pull request #414:
URL: https://github.com/apache/incubator-daffodil/pull/414#discussion_r486328224



##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -1114,4 +1115,10 @@ trait ElementBase
     case (_, _) => this.subset((floating eq YesNo.No), "Property value floating='yes' is not supported.")
   }
 
+  private lazy val checkInputValueCalcExpression: Boolean = {
+    if (this.inputValueCalcOption.toString.contains("checkConstraints(.)")) {

Review comment:
       Is the idea that this inputValueCalc should throw and error? I created a test around it, but no error is thrown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org