You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/12 03:13:47 UTC
[GitHub] [flink] TisonKun commented on a change in pull request #11054:
[FLINK-15652][K8s] Support for imagePullSecrets K8s option.
TisonKun commented on a change in pull request #11054: [FLINK-15652][K8s] Support for imagePullSecrets K8s option.
URL: https://github.com/apache/flink/pull/11054#discussion_r378020468
##########
File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -288,6 +290,21 @@ public static ResourceRequirements getResourceRequirements(int mem, double cpu)
.build();
}
+ /**
+ * Parses comma-separated list of imagePullSecrets into K8s-understandable format.
+ */
+ public static LocalObjectReference[] parseImagePullSecrets(@Nullable String imagePullSecrets) {
Review comment:
IIRC the community introduce a list type config option. You can refer to `PipelineOptions.JARS` for an example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services