You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/25 17:07:31 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #2082: 2078 docs for approx functions

alamb commented on a change in pull request #2082:
URL: https://github.com/apache/arrow-datafusion/pull/2082#discussion_r835460955



##########
File path: docs/source/user-guide/sql/aggregate_functions.md
##########
@@ -0,0 +1,69 @@
+# Aggregate Functions
+
+Aggregate functions operate on a set of values to compute a single result.
+
+## General
+
+### min

Review comment:
       I think writing nice / proper documentation for SQL is a large undertaking.
   
   For standard SQL functions, perhaps we can simply link to pre-existing documentation, such as: https://www.postgresql.org/docs/current/functions-aggregate.html and focus DataFusion documentation on what is different / specific to datafusion (such as`approx_percentile_cont`, `approx_median` and `approx_percentile_cont_with_weight`)?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org