[GitHub] spark pull request #18959: [SPARK-18394][SQL] Make an AttributeSet.toSeq out...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18959#discussion_r133531947
  
    --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/AttributeSetSuite.scala ---
    @@ -78,4 +78,34 @@ class AttributeSetSuite extends SparkFunSuite {
         assert(aSet == aSet)
         assert(aSet == AttributeSet(aUpper :: Nil))
       }
    +
    +  test("SPARK-18394 keep a deterministic output order along with attribute names") {
    --- End diff --
    
    Modify this test case. Add a scenario in which the attribute set has two columns have the same name but different ids? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org