[GitHub] [pulsar] sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #5701: [issues 5698]Handle replicator producer as generated name producer
URL: https://github.com/apache/pulsar/pull/5701#discussion_r348079098
 
 

 ##########
 File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/service/PersistentTopicTest.java
 ##########
 @@ -430,6 +430,30 @@ public void testProducerOverwrite() throws Exception {
         Assert.assertEquals(topic.getProducers().size(), 1);
 
         topic.getProducers().values().forEach(producer -> Assert.assertEquals(producer.getEpoch(), 2));
+
+        topic.removeProducer(producer4);
+        Assert.assertEquals(topic.getProducers().size(), 0);
+
+        Producer producer5= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1",
+                role, false, null, SchemaVersion.Latest, 1, false);
+
+        topic.addProducer(producer5);
+        Assert.assertEquals(topic.getProducers().size(), 1);
+
+        Producer producer6= new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1",
 
 Review comment:
   ```suggestion
           Producer producer6 = new Producer(topic, serverCnx, 2 /* producer id */, "pulsar.repl.cluster1",
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services