You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/22 03:21:43 UTC
[GitHub] [cloudstack] nvazquez opened a new pull request #4851: [Vmware] Fix worker VMs hardware version small bug
nvazquez opened a new pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851
### Description
This PR fixes a small bug when explicitly setting VM hardware versions lower than version 10.
Vmware expects the hardware version in format: `vmx-DD` where DD is a two-digit representation of the virtual hardware version. For hardware version lower than 10, CloudStack was not using to digits for the hardware version number, which ended up on an error while creating worker VMs. (`vmx-8` for example instead of `vmx-08`)
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [x] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-813289042
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804518947
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-805029529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803741096
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests [S]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803822105
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804254888
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804142597
Rebased 4.15 and added unit tests - @rhtyd @sureshanaparti @DaanHoogland can you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-813983132
> @DaanHoogland are you lgtm on this?
I am @rhtyd , awaiting @andrijapanicsb 's thoughts though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-813991170
LGTM, merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803802655
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804517945
@blueorangutan test centos7 vmware67-u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#discussion_r598806423
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -3292,6 +3292,21 @@ public int getVirtualHardwareVersion() throws Exception {
return vhOption.getHwVersion();
}
+ /**
+ * Return a hardware version string in the format expected by Vmware
+ * Format: "vmx-DD" where DD represents the hardware version number
+ */
+ public String getVmxFormattedVirtualHardwareVersion() throws Exception {
Review comment:
Done thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803782581
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803782325
@nvazquez all bug fixes should go to 4.15, I've changed base/branch against 4.15.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804798368
<b>Trillian test result (tid-201)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 97423 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t201-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 58 look OK, 28 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
test_01_port_fwd_on_src_nat | `Failure` | 609.69 | test_network.py
test_02_port_fwd_on_non_src_nat | `Failure` | 608.10 | test_network.py
test_reboot_router | `Failure` | 399.26 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 607.48 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 609.07 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 612.07 | test_network.py
test_05_deploy_vm_with_extraconfig_vmware | `Error` | 685.68 | test_deploy_vm_extra_config_data.py
test_01_nic | `Error` | 723.27 | test_nic.py
test_01_ping_in_vr_success | `Failure` | 15.34 | test_diagnostics.py
test_03_ping_in_ssvm_success | `Failure` | 15.36 | test_diagnostics.py
test_05_ping_in_cpvm_success | `Failure` | 15.33 | test_diagnostics.py
test_isolate_network_password_server | `Failure` | 216.60 | test_password_server.py
test_02_vpc_privategw_static_routes | `Failure` | 861.32 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 841.59 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 1135.56 | test_privategw_acl.py
test_01_disableHumanReadableLogs | `Error` | 602.77 | test_human_readable_logs.py
test_02_enableHumanReadableLogs | `Error` | 602.65 | test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 470.25 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 528.79 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 197.71 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 237.96 | test_internal_lb.py
test_01_deploy_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.01 | test_kubernetes_supported_versions.py
test_nested_virtualization_vmware | `Error` | 936.65 | test_nested_virtualization.py
test_router_dhcphosts | `Failure` | 157.30 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 167.56 | test_router_dhcphosts.py
test_router_dhcp_opts | `Error` | 609.05 | test_router_dhcphosts.py
test_router_dns_guestipquery | `Failure` | 456.53 | test_router_dns.py
test_router_dns_guestipquery | `Failure` | 456.34 | test_router_dnsservice.py
test_02_routervm_iptables_policies | `Error` | 681.99 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 753.91 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 235.38 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 238.48 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 289.81 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 344.40 | test_routers_network_ops.py
test_03_RVR_Network_check_router_state | `Error` | 729.32 | test_routers_network_ops.py
test_01_router_internal_basic | `Error` | 602.79 | test_routers.py
test_02_router_internal_adv | `Error` | 602.72 | test_routers.py
test_04_restart_network_wo_cleanup | `Error` | 604.80 | test_routers.py
test_01_scale_vm | `Error` | 604.59 | test_scale_vm.py
test_04_change_offering_small | `Failure` | 719.34 | test_service_offerings.py
test_01_snapshot_root_disk | `Error` | 649.63 | test_snapshots.py
test_03_ssvm_internals | `Error` | 602.73 | test_ssvm.py
test_04_cpvm_internals | `Error` | 602.73 | test_ssvm.py
test_05_stop_ssvm | `Error` | 673.83 | test_ssvm.py
test_06_stop_cpvm | `Error` | 688.86 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 700.02 | test_ssvm.py
test_08_reboot_cpvm | `Error` | 614.07 | test_ssvm.py
test_09_destroy_ssvm | `Error` | 668.42 | test_ssvm.py
test_10_destroy_cpvm | `Error` | 661.59 | test_ssvm.py
ContextSuite context=TestVAppsVM>:setup | `Error` | 42.17 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 607.62 | test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots | `Failure` | 696.41 | test_vm_snapshots.py
test_01_create_vm_snapshots | `Failure` | 604.86 | test_vm_snapshots.py
test_02_revert_vm_snapshots | `Failure` | 617.22 | test_vm_snapshots.py
test_03_delete_vm_snapshots | `Failure` | 0.02 | test_vm_snapshots.py
test_01_create_volume | `Failure` | 631.06 | test_volumes.py
test_02_attach_volume | `Failure` | 607.79 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 914.16 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 905.73 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 789.06 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 746.83 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 875.76 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 908.82 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 774.17 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 766.94 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 427.19 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 312.87 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 306.88 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-805029529
<b>Trillian test result (tid-212)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50793 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t212-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_diagnostics.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 76 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_10_traceroute_in_vr | `Failure` | 61.15 | test_diagnostics.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 794.08 | test_kubernetes_clusters.py
ContextSuite context=TestVAppsVM>:setup | `Error` | 44.35 | test_vm_life_cycle.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 524.78 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Failure` | 337.20 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Failure` | 288.44 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803822366
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-813602196
<b>Trillian test result (tid-349)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36168 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t349-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Smoke tests completed. 84 look OK, 2 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 74.07 | test_kubernetes_clusters.py
test_01_migrate_VM_and_root_volume | `Error` | 69.26 | test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks | `Error` | 48.04 | test_vm_life_cycle.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#discussion_r598441562
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -3292,6 +3292,21 @@ public int getVirtualHardwareVersion() throws Exception {
return vhOption.getHwVersion();
}
+ /**
+ * Return a hardware version string in the format expected by Vmware
+ * Format: "vmx-DD" where DD represents the hardware version number
+ */
+ public String getVmxFormattedVirtualHardwareVersion() throws Exception {
Review comment:
Can you add a quick unit test for the same @nvazquez ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804140189
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-812989401
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803740887
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804518283
@nvazquez unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, centos8, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-centos8, kvm-ubuntu, xenserver-71, xenserver-65sp1, vmware-67u3, vmware-65u2, vmware-60u2, vmware-55u3, xcpng76, xcpng80, xcpng81, xenserver-74, xcpng74`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-806421278
<b>Trillian test result (tid-256)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40738 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t256-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 82 look OK, 4 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_DeployVmAntiAffinityGroup_in_project | `Error` | 64.04 | test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup | `Error` | 36.41 | test_affinity_groups.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 26.67 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 34.20 | test_kubernetes_clusters.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.37 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-812996132
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_multiplication_x: debian. SL-JID 314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-806007711
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804792419
<b>[S] Trillian test result (tid-196)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 108678 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4851-t196-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vm_extra_config_data.py
Intermittent failure detected: /marvin/tests/smoke/test_human_readable_logs.py
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_loadbalance.py
Intermittent failure detected: /marvin/tests/smoke/test_nested_virtualization.py
Intermittent failure detected: /marvin/tests/smoke/test_network.py
Intermittent failure detected: /marvin/tests/smoke/test_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_password_server.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dns.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dnsservice.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_iptables_default_policy.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermittent failure detected: /marvin/tests/smoke/test_routers.py
Intermittent failure detected: /marvin/tests/smoke/test_scale_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_service_offerings.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Smoke tests completed. 59 look OK, 27 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_create_lb_rule_src_nat | `Failure` | 308.06 | test_loadbalance.py
test_02_create_lb_rule_non_nat | `Failure` | 36.06 | test_loadbalance.py
test_assign_and_removal_lb | `Failure` | 38.96 | test_loadbalance.py
test_01_port_fwd_on_src_nat | `Failure` | 646.63 | test_network.py
test_02_port_fwd_on_non_src_nat | `Failure` | 670.45 | test_network.py
test_reboot_router | `Failure` | 479.12 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 607.64 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 611.47 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 657.90 | test_network.py
test_01_deployVMInSharedNetwork | `Error` | 785.39 | test_network.py
test_02_verifyRouterIpAfterNetworkRestart | `Error` | 666.88 | test_network.py
test_03_destroySharedNetwork | `Failure` | 1.05 | test_network.py
ContextSuite context=TestSharedNetwork>:teardown | `Error` | 2.13 | test_network.py
test_05_deploy_vm_with_extraconfig_vmware | `Error` | 679.63 | test_deploy_vm_extra_config_data.py
test_01_nic | `Error` | 729.60 | test_nic.py
test_isolate_network_password_server | `Failure` | 158.12 | test_password_server.py
test_02_vpc_privategw_static_routes | `Failure` | 838.38 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 835.02 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 996.15 | test_privategw_acl.py
test_01_disableHumanReadableLogs | `Error` | 602.95 | test_human_readable_logs.py
test_02_enableHumanReadableLogs | `Error` | 602.81 | test_human_readable_logs.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 362.76 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 450.49 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 206.72 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Error` | 262.50 | test_internal_lb.py
test_01_deploy_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_upgrade_kubernetes_cluster | `Failure` | 0.01 | test_kubernetes_clusters.py
test_04_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_deploy_invalid_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_deploy_and_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.01 | test_kubernetes_supported_versions.py
test_nested_virtualization_vmware | `Error` | 786.71 | test_nested_virtualization.py
test_router_dhcphosts | `Failure` | 157.30 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPHosts>:teardown | `Error` | 170.63 | test_router_dhcphosts.py
test_router_dhcp_opts | `Error` | 610.25 | test_router_dhcphosts.py
test_router_dns_guestipquery | `Failure` | 454.68 | test_router_dns.py
test_router_dns_guestipquery | `Failure` | 455.56 | test_router_dnsservice.py
test_02_routervm_iptables_policies | `Error` | 689.40 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 767.72 | test_routers_iptables_default_policy.py
test_01_isolate_network_FW_PF_default_routes_egress_true | `Failure` | 235.59 | test_routers_network_ops.py
test_02_isolate_network_FW_PF_default_routes_egress_false | `Failure` | 242.66 | test_routers_network_ops.py
test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | `Failure` | 296.75 | test_routers_network_ops.py
test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | `Failure` | 294.95 | test_routers_network_ops.py
test_03_RVR_Network_check_router_state | `Error` | 734.68 | test_routers_network_ops.py
test_01_router_internal_basic | `Error` | 602.76 | test_routers.py
test_02_router_internal_adv | `Error` | 604.18 | test_routers.py
test_04_restart_network_wo_cleanup | `Error` | 606.14 | test_routers.py
test_01_scale_vm | `Error` | 604.72 | test_scale_vm.py
test_04_change_offering_small | `Error` | 94.24 | test_service_offerings.py
test_01_snapshot_root_disk | `Error` | 648.89 | test_snapshots.py
test_03_ssvm_internals | `Error` | 602.88 | test_ssvm.py
test_04_cpvm_internals | `Error` | 602.78 | test_ssvm.py
test_05_stop_ssvm | `Error` | 672.51 | test_ssvm.py
test_06_stop_cpvm | `Error` | 660.39 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 702.00 | test_ssvm.py
test_08_reboot_cpvm | `Error` | 610.03 | test_ssvm.py
test_09_reboot_ssvm_forced | `Error` | 755.05 | test_ssvm.py
test_10_reboot_cpvm_forced | `Error` | 665.89 | test_ssvm.py
test_11_destroy_ssvm | `Error` | 659.40 | test_ssvm.py
test_12_destroy_cpvm | `Error` | 663.40 | test_ssvm.py
ContextSuite context=TestVAppsVM>:setup | `Error` | 46.33 | test_vm_life_cycle.py
test_09_expunge_vm | `Failure` | 424.58 | test_vm_life_cycle.py
test_10_attachAndDetach_iso | `Failure` | 608.02 | test_vm_life_cycle.py
test_change_service_offering_for_vm_with_snapshots | `Failure` | 725.60 | test_vm_snapshots.py
test_01_create_vm_snapshots | `Failure` | 604.77 | test_vm_snapshots.py
test_02_revert_vm_snapshots | `Failure` | 601.50 | test_vm_snapshots.py
test_03_delete_vm_snapshots | `Failure` | 0.02 | test_vm_snapshots.py
test_01_create_volume | `Failure` | 734.60 | test_volumes.py
test_02_attach_volume | `Failure` | 607.94 | test_volumes.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Error` | 913.14 | test_vpc_redundant.py
test_02_redundant_VPC_default_routes | `Error` | 893.73 | test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Error` | 789.19 | test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics | `Error` | 744.72 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 867.81 | test_vpc_redundant.py
test_05_rvpc_multi_tiers | `Error` | 901.86 | test_vpc_redundant.py
test_01_VPC_nics_after_destroy | `Failure` | 773.74 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Failure` | 766.79 | test_vpc_router_nics.py
test_01_redundant_vpc_site2site_vpn | `Failure` | 441.74 | test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options | `Error` | 295.54 | test_vpc_vpn.py
test_01_vpc_site2site_vpn | `Error` | 337.97 | test_vpc_vpn.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804254566
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-812989264
@DaanHoogland are you lgtm on this?
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804519211
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803740300
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803734179
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-813288543
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-804271224
Packaging result: :heavy_check_mark: centos7 :heavy_check_mark: centos8 :heavy_check_mark: debian. SL-JID 204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4851: [Vmware] Fix worker VMs hardware version small bug
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4851:
URL: https://github.com/apache/cloudstack/pull/4851#issuecomment-803734276
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. [S]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org