You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/04/25 14:01:41 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #6115: Update to arrow 38
tustvold opened a new pull request, #6115:
URL: https://github.com/apache/arrow-datafusion/pull/6115
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #6115: Update to arrow 38
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6115:
URL: https://github.com/apache/arrow-datafusion/pull/6115#issuecomment-1521871347
🤔 there appear to be more changes needed to tests in other modules
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6115: Update to arrow 38
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6115:
URL: https://github.com/apache/arrow-datafusion/pull/6115#discussion_r1176566626
##########
datafusion/core/src/physical_plan/sorts/sort.rs:
##########
@@ -1089,7 +1089,7 @@ mod tests {
#[tokio::test]
async fn test_sort_fetch_memory_calculation() -> Result<()> {
// This test mirrors down the size from the example above.
- let avg_batch_size = 6000;
+ let avg_batch_size = 5000;
Review Comment:
Arrays are smaller because of https://github.com/apache/arrow-rs/pull/4061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #6115: Update to arrow 38
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #6115:
URL: https://github.com/apache/arrow-datafusion/pull/6115#discussion_r1176638258
##########
datafusion/core/tests/sqllogictests/test_files/arrow_typeof.slt:
##########
@@ -303,7 +303,7 @@ select arrow_cast('30 minutes', 'Interval(MonthDayNano)');
## Duration
-query error DataFusion error: Error during planning: Cannot automatically convert Interval\(MonthDayNano\) to Duration\(Second\)
+query error DataFusion error: This feature is not implemented: Can't create a scalar from array of type "Duration\(Second\)"
Review Comment:
I think this is the result of https://github.com/apache/arrow-rs/pull/4020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #6115: Update to arrow 38
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #6115:
URL: https://github.com/apache/arrow-datafusion/pull/6115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org