You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "salapenar-max (via GitHub)" <gi...@apache.org> on 2026/10/09 19:53:57 UTC
[PR] fix(config_center): do not panic when an Apollo key is both a leaf and a parent [dubbo-go]
salapenar-max opened a new pull request, #3758:
URL: https://github.com/apache/dubbo-go/pull/3758
## What
`makeNestedMap` turns flat Apollo properties into a nested map for YAML namespaces. When one key is a prefix of another (`a.b=1` and `a.b.c=2`), the intermediate value is a string. The old type assertion then panics. That is item 3 in #3552.
## Fix
The descent now uses a comma-ok check. If the value already stored is not a map, it is replaced with one. If a scalar arrives after the nested map exists, the map is kept so the longer key is not erased. Either visit order keeps `a.b.c` and drops the conflicting scalar. Keys that do not overlap are unchanged.
This pull request covers only that panic. It does not take the rest of #3552, so it uses `Refs` instead of `Fixes` and should not close the issue. The forking-cluster goroutine leak already has an open pull request, #3436.
## Tests
`go test -count=1 ./config_center/apollo/`
`TestMakeNestedMap` checks ordinary dotted keys, and it repeats the leaf-and-parent case so both map-iteration orders stay panic-free and keep the nested value plus the sibling key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(config_center): do not panic when an Apollo key is both a leaf and a parent [dubbo-go]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3758:
URL: https://github.com/apache/dubbo-go/pull/3758#issuecomment-6088305017
## [Codecov](https://app.codecov.io/gh/apache/dubbo-go/pull/3758?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.95%. Comparing base ([`832124a`](https://app.codecov.io/gh/apache/dubbo-go/commit/832124aaacf0283445d379e935ff5d73695fa84d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`250552c`](https://app.codecov.io/gh/apache/dubbo-go/commit/250552c38f3d555d6f3738db3c06b61e3329538f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #3758 +/- ##
=======================================
Coverage 56.94% 56.95%
=======================================
Files 478 478
Lines 38635 38639 +4
=======================================
+ Hits 21999 22005 +6
+ Misses 14923 14922 -1
+ Partials 1713 1712 -1
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/dubbo-go/pull/3758?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(config_center): do not panic when an Apollo key is both a leaf and a parent [dubbo-go]
Posted by "Alanxtl (via GitHub)" <gi...@apache.org>.
Alanxtl merged PR #3758:
URL: https://github.com/apache/dubbo-go/pull/3758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] fix(config_center): do not panic when an Apollo key is both a leaf and a parent [dubbo-go]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #3758:
URL: https://github.com/apache/dubbo-go/pull/3758#issuecomment-6088207222
## [](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3758) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3758&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_dubbo-go&pullRequest=3758&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo-go&pullRequest=3758&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3758&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_dubbo-go&pullRequest=3758&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_dubbo-go&pullRequest=3758)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org