You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/02/12 12:59:41 UTC

Review Request 30923: LENS-309: Exception while purging query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/
-----------------------------------------------------------

Review request for lens.


Bugs: LENS-309
    https://issues.apache.org/jira/browse/LENS-309


Repository: lens


Description
-------

handles integrity violation while purging


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 

Diff: https://reviews.apache.org/r/30923/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/#review72138
-----------------------------------------------------------


Changes look fine. Can you take care of checkstyle changes being done? I'm thinking no more patches will do any checkstyle changes for existing code.

- Amareshwari Sriramadasu


On Feb. 12, 2015, 11:59 a.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30923/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 11:59 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-309
>     https://issues.apache.org/jira/browse/LENS-309
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> handles integrity violation while purging
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 
> 
> Diff: https://reviews.apache.org/r/30923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/#review72152
-----------------------------------------------------------



lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java
<https://reviews.apache.org/r/30923/#comment118157>

    Please remove this as tests are already running on random ports


- Amareshwari Sriramadasu


On Feb. 12, 2015, 1:02 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30923/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 1:02 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-309
>     https://issues.apache.org/jira/browse/LENS-309
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> handles integrity violation while purging
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 
> 
> Diff: https://reviews.apache.org/r/30923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 1:58 p.m.)


Review request for lens.


Bugs: LENS-309
    https://issues.apache.org/jira/browse/LENS-309


Repository: lens


Description
-------

handles integrity violation while purging


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 

Diff: https://reviews.apache.org/r/30923/diff/


Testing (updated)
-------

After merging master: 


[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO] 
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.200s]
[INFO] Lens .............................................. SUCCESS [1.817s]
[INFO] Lens API .......................................... SUCCESS [6.215s]
[INFO] Lens API for server and extensions ................ SUCCESS [4.999s]
[INFO] Lens Cube ......................................... SUCCESS [6:18.565s]
[INFO] Lens DB storage ................................... SUCCESS [10.963s]
[INFO] Lens Query Library ................................ SUCCESS [4.472s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:44.896s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [24.136s]
[INFO] Lens Server ....................................... SUCCESS [4:25.334s]
[INFO] Lens client ....................................... SUCCESS [20.761s]
[INFO] Lens CLI .......................................... SUCCESS [1:39.095s]
[INFO] Lens Examples ..................................... SUCCESS [0.937s]
[INFO] Lens Distribution ................................. SUCCESS [4.651s]
[INFO] Lens Client Distribution .......................... SUCCESS [6.001s]
[INFO] Lens ML Lib ....................................... SUCCESS [42.912s]
[INFO] Lens Regression ................................... SUCCESS [0.468s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 17:19.359s
[INFO] Finished at: Mon Feb 16 08:08:16 UTC 2015
[INFO] Final Memory: 99M/1300M
[INFO] ------------------------------------------------------------------------


Thanks,

Rajat Khandelwal

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/
-----------------------------------------------------------

(Updated Feb. 16, 2015, 1:19 p.m.)


Review request for lens.


Bugs: LENS-309
    https://issues.apache.org/jira/browse/LENS-309


Repository: lens


Description
-------

handles integrity violation while purging


Diffs
-----

  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 

Diff: https://reviews.apache.org/r/30923/diff/


Testing (updated)
-------

Getting test failure in ml lib:

```
trainAndEval(org.apache.lens.ml.TestMLResource)  Time elapsed: 1.555 sec  <<< FAILURE!
java.lang.AssertionError: expected [SUCCESSFUL] but found [FAILED]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:494)
	at org.testng.Assert.assertEquals(Assert.java:123)
	at org.testng.Assert.assertEquals(Assert.java:165)
	at org.apache.lens.ml.TestMLResource.trainAndEval(TestMLResource.java:206)

```


Thanks,

Rajat Khandelwal

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/#review72298
-----------------------------------------------------------

Ship it!


Please update test results

- Amareshwari Sriramadasu


On Feb. 12, 2015, 1:29 p.m., Rajat Khandelwal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30923/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2015, 1:29 p.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-309
>     https://issues.apache.org/jira/browse/LENS-309
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> handles integrity violation while purging
> 
> 
> Diffs
> -----
> 
>   lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
>   lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 
> 
> Diff: https://reviews.apache.org/r/30923/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rajat Khandelwal
> 
>

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/
-----------------------------------------------------------

(Updated Feb. 12, 2015, 6:59 p.m.)


Review request for lens.


Bugs: LENS-309
    https://issues.apache.org/jira/browse/LENS-309


Repository: lens


Description
-------

handles integrity violation while purging


Diffs (updated)
-----

  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 

Diff: https://reviews.apache.org/r/30923/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Re: Review Request 30923: LENS-309: Exception while purging query

Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30923/
-----------------------------------------------------------

(Updated Feb. 12, 2015, 6:32 p.m.)


Review request for lens.


Bugs: LENS-309
    https://issues.apache.org/jira/browse/LENS-309


Repository: lens


Description
-------

handles integrity violation while purging


Diffs (updated)
-----

  lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java dd2cff2c6f22b22058918abf2351091de25dfafb 
  lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java ec2656fffaf72e19206e41a18d1ae43687d71044 

Diff: https://reviews.apache.org/r/30923/diff/


Testing
-------


Thanks,

Rajat Khandelwal