You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/04/13 21:07:08 UTC
[GitHub] [druid] himanshug opened a new pull request #9695:
[WIP]druid-pac4j:add custom SSL handling to
com.nimbusds.oauth2.sdk.http.HTTPRequest objects
himanshug opened a new pull request #9695: [WIP]druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695
Fixes issue reported in https://github.com/apache/druid/pull/8992#issuecomment-612815336
### Description
One such problem, reported in https://github.com/apache/druid/pull/8992#issuecomment-609586100 , was fixed by #9637 . However, pac4j appears to have different code paths with different mechanisms to make HTTP connection and this PR updates those.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
himanshug commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614378502
@jihoonson @clintropolis thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
himanshug commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614174834
@jihoonson not sure if you already prep the new RC for 0.18.0 , if not , can you please approve this so that we can get it in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614187634
@himanshug sorry, I've already created RC 2 artifacts and am testing them. Thinking to start a new vote around noon today. Can this PR go into the next release?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614320361
Good news. RC2 vote failed. Let's add this PR to RC3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] himanshug commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
himanshug commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614203259
that would be ok, unless we end up doing a RC3 for some reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on issue #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
jihoonson commented on issue #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695#issuecomment-614206246
Thanks. Hopefully not 😅.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9695: druid-pac4j:add custom
SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9695: druid-pac4j:add custom SSL handling to com.nimbusds.oauth2.sdk.http.HTTPRequest objects
URL: https://github.com/apache/druid/pull/9695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org