You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2014/08/01 19:56:39 UTC
Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1958
https://issues.apache.org/jira/browse/OOZIE-1958
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
Diffs
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
Diff: https://reviews.apache.org/r/24187/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/#review49867
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/24187/#comment87270>
This will break if someone has same env key repeated twice in map.env or am.env (the hadoop behavior that caused problem with the current issue was to support those cases). For eg: PATH
It should be Map<String, List<String>> instead of Map<String, String>
- Rohini Palaniswamy
On Aug. 6, 2014, 9:52 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24187/
> -----------------------------------------------------------
>
> (Updated Aug. 6, 2014, 9:52 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1958
> https://issues.apache.org/jira/browse/OOZIE-1958
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
>
> Diff: https://reviews.apache.org/r/24187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/#review50013
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Aug. 8, 2014, 6:42 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24187/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 6:42 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1958
> https://issues.apache.org/jira/browse/OOZIE-1958
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
>
> Diff: https://reviews.apache.org/r/24187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 6:42 a.m.)
Review request for oozie.
Changes
-------
fixed rohinit's comment
Bugs: OOZIE-1958
https://issues.apache.org/jira/browse/OOZIE-1958
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
Diff: https://reviews.apache.org/r/24187/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/
-----------------------------------------------------------
(Updated Aug. 6, 2014, 9:52 p.m.)
Review request for oozie.
Changes
-------
thanks mona for review. fixed naming convention
did e2e test using hadoop 2.x cluster and confirmed it works.
Bugs: OOZIE-1958
https://issues.apache.org/jira/browse/OOZIE-1958
Repository: oozie-git
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
Diff: https://reviews.apache.org/r/24187/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request 24187: OOZIE-1958 address duplication of env variables in
oozie.launcher.yarn.app.mapreduce.am.env when running with uber mode
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24187/#review49628
-----------------------------------------------------------
+1 pending minor comment about naming and checking via e-2-e test
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/24187/#comment86870>
keep naming consistent i.e.
launcherEnvMap and launcherEnvMapStr
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/24187/#comment86865>
false formatting change.. but its ok to include
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/24187/#comment86866>
same as above
- Mona Chitnis
On Aug. 1, 2014, 5:56 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24187/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2014, 5:56 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1958
> https://issues.apache.org/jira/browse/OOZIE-1958
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1958?filter=-1
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 94b55cf
> core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 72a137c
>
> Diff: https://reviews.apache.org/r/24187/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>