You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2023/10/05 21:58:25 UTC

[PR] Update es read query to not use body [airflow]

dstandish opened a new pull request, #34792:
URL: https://github.com/apache/airflow/pull/34792

   The argument is deprecated and it's advised to use the params directly.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "Owen-CH-Leung (via GitHub)" <gi...@apache.org>.
Owen-CH-Leung commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1751023560

   Hmm Indeed. It looks like `body` param is getting deprecated soon. I was diving into the `v8.10.0` library (the latest v8 one) here, and I believe it will print this warning message (but strange I didn't see this warning when I was running the test / testing the remote logging capability )
   
   https://github.com/elastic/elasticsearch-py/blob/v8.10.0/elasticsearch/_sync/client/utils.py#L393-L404
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1750875905

   cc @Owen-CH-Leung you mentioned the count api in https://github.com/apache/airflow/pull/33135/files#r1285877721


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1802976077

   OK I tested this change locally and it does require bumping min elasticsearch version to 8.10 (which i have updated the provider settings to do)
   
   So, presuming tests pass, this should be good to go


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1749736819

   When was it deprecated / when was params directly supported? Just trying to figure out if we have a new min version of ES we support or something.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1803597740

   Nice. I like when our provider's min versions of dependencies got update. I am actualy thinking of adding a check for it - i.e. attempting to install lowest versions of dependencies possible and running our tests on it. That would be an ulitmate check whether our min requirements 
   
   I captured it here  https://github.com/apache/airflow/issues/35549  and I will likely find some time to implement it in the coming months, though if someone else would like to pick it up, I am happy to guide them and work together.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1751057934

   I fixed the calls so that they work with 8.10... 
   
   I have a hunch that to fix the _tests_ in this PR we'll need to bump es version to 8.10


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #34792:
URL: https://github.com/apache/airflow/pull/34792#issuecomment-1749746401

   Yeah saw test failures.  I'm seeing the deprecation at version 8.1
   
   We have it pinned at >8, <9 it seems.  marked draft for now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update es read query to not use body [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34792:
URL: https://github.com/apache/airflow/pull/34792


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org