You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/01/14 01:16:48 UTC

[GitHub] [beam] benWize commented on pull request #16200: [BEAM-11808][BEAM-9879] Support aggregate functions with two arguments

benWize commented on pull request #16200:
URL: https://github.com/apache/beam/pull/16200#issuecomment-1012661753


   I tried adding a new test with the query  `SELECT string_agg("s", @separator) FROM (SELECT 1)`  and It failed in
   
   https://github.com/apache/beam/blob/f45b17242ef125e1ac0f303cc231e9bab614c207/sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java#L186
   
   I tried adding a new case for ResolvedParameter but I couldn't get the value for delimiter there, it is undefined at that point, I'm not sure how I should handle that case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org