You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/11/03 20:18:13 UTC
[GitHub] [mynewt-core] supervillain101 opened a new pull request #2407: This change adds protection against rollover at high altitudes.
supervillain101 opened a new pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407
Fix was provided by Bosch.
At high altitudes there is a potential for rollover in the compensate_pressure() function. To prevent that, Bosch provided a fix with a divide by 10 in the affected code and then a multiply by 10 after to bring the final value back to the expected value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721861408
I agree with what @wes3 is saying, it makes sense to use parenthesis above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721870726
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/bmp388/src/bmp388.c
<details>
```diff
@@ -1314,65 +1333,75 @@
+ partial_data5;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),(uint32_t)(sensitivity&0xffffffff));
+ BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),
+ (uint32_t)(sensitivity&0xffffffff));
#endif
partial_data1 = (sensitivity / 16777216) * uncomp_data->pressure;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),(uint32_t)(partial_data1&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),
+ (uint32_t)(partial_data1&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p10 = %d\n", reg_calib_data->par_p10);
#endif
partial_data2 = reg_calib_data->par_p10 * t_lin;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p9 = %d\n", reg_calib_data->par_p9);
#endif
partial_data3 = partial_data2 + (65536 * reg_calib_data->par_p9);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (partial_data3 * uncomp_data->pressure) / 8192;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
partial_data5 = (partial_data4 * (uncomp_data->pressure / 10)) / 512;
partial_data5 = partial_data5 * 10;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),(uint32_t)(partial_data5&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),
+ (uint32_t)(partial_data5&0xffffffff));
#endif
partial_data6 = (int64_t)((uint64_t)uncomp_data->pressure * (uint64_t)uncomp_data->pressure);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),(uint32_t)(partial_data6&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),
+ (uint32_t)(partial_data6&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p11 = %d\n", reg_calib_data->par_p11);
#endif
partial_data2 = (reg_calib_data->par_p11 * partial_data6) / 65536;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
#endif
partial_data3 = (partial_data2 * uncomp_data->pressure) / 128;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (offset / 4) + partial_data1 + partial_data5 + partial_data3;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
comp_press = (uint32_t)(partial_data4 * 25 / 1099511627776ULL);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane commented on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
vrahane commented on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721471367
@supervillain101 What I meant by that is, we generally write commit messages like this:
`sensors/bmp388: Adding protection against rollover at high altitudes.`
It gives a small description of the fix along with the module that you are changing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot removed a comment on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721386444
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/bmp388/src/bmp388.c
<details>
```diff
@@ -1314,65 +1333,75 @@
+ partial_data5;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),(uint32_t)(sensitivity&0xffffffff));
+ BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),
+ (uint32_t)(sensitivity&0xffffffff));
#endif
partial_data1 = (sensitivity / 16777216) * uncomp_data->pressure;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),(uint32_t)(partial_data1&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),
+ (uint32_t)(partial_data1&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p10 = %d\n", reg_calib_data->par_p10);
#endif
partial_data2 = reg_calib_data->par_p10 * t_lin;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p9 = %d\n", reg_calib_data->par_p9);
#endif
partial_data3 = partial_data2 + (65536 * reg_calib_data->par_p9);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (partial_data3 * uncomp_data->pressure) / 8192;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
partial_data5 = (partial_data4 * uncomp_data->pressure / 10) / 512;
partial_data5 = partial_data5 * 10;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),(uint32_t)(partial_data5&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),
+ (uint32_t)(partial_data5&0xffffffff));
#endif
partial_data6 = (int64_t)((uint64_t)uncomp_data->pressure * (uint64_t)uncomp_data->pressure);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),(uint32_t)(partial_data6&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),
+ (uint32_t)(partial_data6&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p11 = %d\n", reg_calib_data->par_p11);
#endif
partial_data2 = (reg_calib_data->par_p11 * partial_data6) / 65536;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
#endif
partial_data3 = (partial_data2 * uncomp_data->pressure) / 128;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (offset / 4) + partial_data1 + partial_data5 + partial_data3;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
comp_press = (uint32_t)(partial_data4 * 25 / 1099511627776ULL);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] vrahane merged pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
vrahane merged pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] supervillain101 commented on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
supervillain101 commented on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721863442
@vrahane Changes made to parens and commit message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2407: This change adds protection against rollover at high altitudes.
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on pull request #2407:
URL: https://github.com/apache/mynewt-core/pull/2407#issuecomment-721386444
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/bmp388/src/bmp388.c
<details>
```diff
@@ -1314,65 +1333,75 @@
+ partial_data5;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),(uint32_t)(sensitivity&0xffffffff));
+ BMP388_LOG_ERROR("*****sensitivity high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((sensitivity)>>32),
+ (uint32_t)(sensitivity&0xffffffff));
#endif
partial_data1 = (sensitivity / 16777216) * uncomp_data->pressure;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),(uint32_t)(partial_data1&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data1 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data1)>>32),
+ (uint32_t)(partial_data1&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p10 = %d\n", reg_calib_data->par_p10);
#endif
partial_data2 = reg_calib_data->par_p10 * t_lin;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p9 = %d\n", reg_calib_data->par_p9);
#endif
partial_data3 = partial_data2 + (65536 * reg_calib_data->par_p9);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (partial_data3 * uncomp_data->pressure) / 8192;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
partial_data5 = (partial_data4 * uncomp_data->pressure / 10) / 512;
partial_data5 = partial_data5 * 10;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),(uint32_t)(partial_data5&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data5 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data5)>>32),
+ (uint32_t)(partial_data5&0xffffffff));
#endif
partial_data6 = (int64_t)((uint64_t)uncomp_data->pressure * (uint64_t)uncomp_data->pressure);
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),(uint32_t)(partial_data6&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data6 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data6)>>32),
+ (uint32_t)(partial_data6&0xffffffff));
BMP388_LOG_ERROR("*****reg_calib_data->par_p11 = %d\n", reg_calib_data->par_p11);
#endif
partial_data2 = (reg_calib_data->par_p11 * partial_data6) / 65536;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),(uint32_t)(partial_data2&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data2 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data2)>>32),
+ (uint32_t)(partial_data2&0xffffffff));
#endif
partial_data3 = (partial_data2 * uncomp_data->pressure) / 128;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),(uint32_t)(partial_data3&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data3 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data3)>>32),
+ (uint32_t)(partial_data3&0xffffffff));
#endif
partial_data4 = (offset / 4) + partial_data1 + partial_data5 + partial_data3;
#if COMPENSTATE_DEBUG
- BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),(uint32_t)(partial_data4&0xffffffff));
+ BMP388_LOG_ERROR("*****partial_data4 high32bit = 0x%x low32bit = 0x%x\n", (uint32_t)((partial_data4)>>32),
+ (uint32_t)(partial_data4&0xffffffff));
#endif
comp_press = (uint32_t)(partial_data4 * 25 / 1099511627776ULL);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org