You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/09 13:18:51 UTC

[kyuubi] branch master updated: [KYUUBI #4283] [TEST] Fix flaky test in SessionsResourceSuite

This is an automated email from the ASF dual-hosted git repository.

chengpan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new 363e798b7 [KYUUBI #4283] [TEST] Fix flaky test in SessionsResourceSuite
363e798b7 is described below

commit 363e798b7ccb636eb224c5a7caa1eaaa475a0cc9
Author: Cheng Pan <ch...@apache.org>
AuthorDate: Thu Feb 9 13:18:42 2023 +0000

    [KYUUBI #4283] [TEST] Fix flaky test in SessionsResourceSuite
    
    ### _Why are the changes needed?_
    
    This PR proposes to fix the flaky test
    ```
    - post session exception if failed to open engine session *** FAILED ***
    ```
    which was introduced in #4185
    
    https://github.com/apache/kyuubi/actions/runs/4131523933/jobs/7139249142
    
    ### _How was this patch tested?_
    - [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
    
    Closes #4283 from pan3793/flaky.
    
    Closes #4283
    
    f5c70077 [Cheng Pan] [TEST] Fix flaky test in SessionsResourceSuite
    
    Authored-by: Cheng Pan <ch...@apache.org>
    Signed-off-by: Cheng Pan <ch...@apache.org>
---
 .../scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
index 1357245ad..dcd4d5904 100644
--- a/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
+++ b/kyuubi-server/src/test/scala/org/apache/kyuubi/server/api/v1/SessionsResourceSuite.scala
@@ -296,7 +296,7 @@ class SessionsResourceSuite extends KyuubiFunSuite with RestFrontendTestHelper {
       response = webTarget.path(s"api/v1/sessions/$sessionHandle").request().get()
       // will meet json parse exception with response.readEntity(classOf[KyuubiSessionEvent])
       val sessionEvent = response.readEntity(classOf[String])
-      assert(sessionEvent.contains("SparkException: Master"))
+      assert(sessionEvent.contains("The last 10 line(s) of log are:"))
     }
   }
 }