You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/09 03:41:59 UTC
[GitHub] [hudi] danny0405 opened a new pull request, #7166: [minor] Refactor the code for CkpMetadata
danny0405 opened a new pull request, #7166:
URL: https://github.com/apache/hudi/pull/7166
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
### Risk level (write none, low medium or high below)
_If medium or high, explain what verification was done to mitigate the risks._
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] SteNicholas commented on a diff in pull request #7166: [MINOR] Refactor the code for CkpMetadata
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #7166:
URL: https://github.com/apache/hudi/pull/7166#discussion_r1017451567
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -61,7 +61,9 @@ public class CkpMetadata implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(CkpMetadata.class);
- protected static final int MAX_RETAIN_CKP_NUM = 3;
+ // 1 is actually enough for fetching the latest pending instant,
+ // keep 3 instants here for purpose of debugging.
+ private static final int MAX_RETAIN_CKP_NUM = 3;
Review Comment:
Could the max retain checkpoint number be configurable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7166: [minor] Refactor the code for CkpMetadata
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7166:
URL: https://github.com/apache/hudi/pull/7166#issuecomment-1308167449
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "690e75b4e1e6aed3d77601d2949ad3e37a950457",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "690e75b4e1e6aed3d77601d2949ad3e37a950457",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 690e75b4e1e6aed3d77601d2949ad3e37a950457 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #7166: [MINOR] Refactor the code for CkpMetadata
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #7166:
URL: https://github.com/apache/hudi/pull/7166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #7166: [minor] Refactor the code for CkpMetadata
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7166:
URL: https://github.com/apache/hudi/pull/7166#issuecomment-1308173601
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "690e75b4e1e6aed3d77601d2949ad3e37a950457",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12891",
"triggerID" : "690e75b4e1e6aed3d77601d2949ad3e37a950457",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 690e75b4e1e6aed3d77601d2949ad3e37a950457 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12891)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #7166: [MINOR] Refactor the code for CkpMetadata
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #7166:
URL: https://github.com/apache/hudi/pull/7166#discussion_r1017473954
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -61,7 +61,9 @@ public class CkpMetadata implements Serializable {
private static final Logger LOG = LoggerFactory.getLogger(CkpMetadata.class);
- protected static final int MAX_RETAIN_CKP_NUM = 3;
+ // 1 is actually enough for fetching the latest pending instant,
+ // keep 3 instants here for purpose of debugging.
+ private static final int MAX_RETAIN_CKP_NUM = 3;
Review Comment:
We do not add user options for internal functionalities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org