You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Michael Osipov (JIRA)" <ji...@codehaus.org> on 2009/07/06 22:13:22 UTC

[jira] Created: (MPIR-163) Invalid url fragment with local license file

Invalid url fragment with local license file
--------------------------------------------

                 Key: MPIR-163
                 URL: http://jira.codehaus.org/browse/MPIR-163
             Project: Maven 2.x Project Info Reports Plugin
          Issue Type: Bug
          Components: dependencies
    Affects Versions: 2.1.1
         Environment: mvn 2.0.10, xp sp2
            Reporter: Michael Osipov
         Attachments: local-license.patch

I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 

I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPIR-163) Invalid url fragment with local license file

Posted by "Michael Osipov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=182735#action_182735 ] 

Michael Osipov commented on MPIR-163:
-------------------------------------

Feel free to improve the patch.

I did not intentionally link to ./license.txt because the license may be created only for the parent.
I have the parent linked only and the modules refer to.

> Invalid url fragment with local license file
> --------------------------------------------
>
>                 Key: MPIR-163
>                 URL: http://jira.codehaus.org/browse/MPIR-163
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 2.1.1
>         Environment: mvn 2.0.10, xp sp2
>            Reporter: Michael Osipov
>         Attachments: local-license.patch
>
>
> I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 
> I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPIR-163) Invalid url fragment with local license file

Posted by "Michael Osipov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244046#action_244046 ] 

Michael Osipov commented on MPIR-163:
-------------------------------------

How am I supposed then to maintain only one copy of the lincense?
I have defined this in my parent pom:
<url>file:///${basedir}/LICENSE.txt</url>

This is of course inherited to my children and it obviously won't work. I don't want to copy the license element to any of my children.

> Invalid url fragment with local license file
> --------------------------------------------
>
>                 Key: MPIR-163
>                 URL: http://jira.codehaus.org/browse/MPIR-163
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 2.1.1
>         Environment: mvn 2.0.10, xp sp2
>            Reporter: Michael Osipov
>         Attachments: local-license.patch
>
>
> I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 
> I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPIR-163) Invalid url fragment with local license file

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244574#action_244574 ] 

Vincent Siveton commented on MPIR-163:
--------------------------------------

Yes it is a known limitation of the basedir... you could define a trunk.dir property in your parent and override it in your modules i.e.

{code}
|trunk.dir
  |_LICENSE.TXT
  |_ pom.xml (parent)
  |_ module\
    |_ pom.xml
{code}

Parent pom.xml:
{code}
  <properties>
    <trunk.dir>${basedir}</trunk.dir>
  </properties>

  <licenses>
    <license>
      <name>XXX</name>
      <url>${trunk.dir}/LICENSE.TXT</ur>
    </license>
  </licenses>
{code}

Module pom.xml:
{code}
  <properties>
    <trunk.dir>${basedir}/..</trunk.dir>
  </properties>
{code}

You could make your LICENSE.TXT on a webserver or on a public svn.

> Invalid url fragment with local license file
> --------------------------------------------
>
>                 Key: MPIR-163
>                 URL: http://jira.codehaus.org/browse/MPIR-163
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 2.1.1
>         Environment: mvn 2.0.10, xp sp2
>            Reporter: Michael Osipov
>         Attachments: local-license.patch
>
>
> I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 
> I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MPIR-163) Invalid url fragment with local license file

Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MPIR-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vincent Siveton closed MPIR-163.
--------------------------------

    Resolution: Won't Fix

License url should be a valid url (file://...)

> Invalid url fragment with local license file
> --------------------------------------------
>
>                 Key: MPIR-163
>                 URL: http://jira.codehaus.org/browse/MPIR-163
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 2.1.1
>         Environment: mvn 2.0.10, xp sp2
>            Reporter: Michael Osipov
>         Attachments: local-license.patch
>
>
> I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 
> I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MPIR-163) Invalid url fragment with local license file

Posted by "Michael Osipov (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MPIR-163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=244642#action_244642 ] 

Michael Osipov commented on MPIR-163:
-------------------------------------

Vincent, I am aware of that workaround but it simply is to tedious. Webserver is one option but the svn stuff is a bit complicated. That repo has to be reachable thru http + the url has to be static, it cannot be a trunk URL. I'd have to update the url manually when I do release:prepare.

> Invalid url fragment with local license file
> --------------------------------------------
>
>                 Key: MPIR-163
>                 URL: http://jira.codehaus.org/browse/MPIR-163
>             Project: Maven 2.x Project Info Reports Plugin
>          Issue Type: Bug
>          Components: dependencies
>    Affects Versions: 2.1.1
>         Environment: mvn 2.0.10, xp sp2
>            Reporter: Michael Osipov
>         Attachments: local-license.patch
>
>
> I've set a local license file from my basedir in my pom. The dependencies tree report lists the license but links to /dependencies.html#LICENSE.txt which is incorrect. See [here|http://java.fckeditor.net/java-demo/dependencies.html] for net.fckeditor:java-core:jar:2.5-beta-1 for the failing testcase. 
> I have patched 2.1.1 which works well, see attachment.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira