[GitHub] [druid] kfaraz commented on a diff in pull request #13231: Mask SQL in ExecutorLifecycle logs for AWS Credentials

[GitBox <gi...@apache.org>]

kfaraz commented on code in PR #13231:
URL: https://github.com/apache/druid/pull/13231#discussion_r997665196


##########
indexing-service/src/main/java/org/apache/druid/indexing/worker/executor/ExecutorLifecycle.java:
##########
@@ -206,6 +225,22 @@ public TaskStatus apply(TaskStatus taskStatus)
     );
   }
 
+  @VisibleForTesting
+  static String maskSensitiveJsonKeys(String taskJson)

Review Comment:
   +1
   Also, please try to avoid writing `@VisibleForTesting` methods in new code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org