You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by robpaveza <gi...@git.apache.org> on 2015/03/18 19:10:18 UTC
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-lib/pull/187
CB-8703: Add support for semver and device-specific targeting of config-file to Windows
Allows config-file to target a virtual "package.appxmanifest" (already supported) and specify versions of Windows via new versions and device-target attributes:
<config-file target="package.appxmanifest" versions=">=8.1.0" ... />
<config.file target="package.appxmanifest" device-target="phone" />
This change also modifies the related <lib-file> and <framework> elements for Windows to rename the "target" attribute to "device-target" in order to align the meaning across elements. ("target" is preserved as an alias in order to be backwards-compatible).
There is a matching PR for cordova-docs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robpaveza/cordova-lib CB-8703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit f4dab3495422ea7e56678d9f478d86e1c35c1c66
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-03-18T17:32:27Z
CB-8703: Add support for semver and device-specific targeting of
config-file to Windows.
This change enables the use of "versions" and "device-target" attributes
on the config-file element when the config-file element targets
package.appxmanifest. This allows for plugins to be more robust in the
face of future versions of Windows which may require introduction of
additional app manifests.
commit 215b3fcb2e9a95f8437b9f6de5074326fbfd724e
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-03-18T17:45:10Z
CB-8703: Merged into head.
Conflicts:
cordova-lib/src/plugman/platforms/windows.js
commit fda0f6c42222cd0ddb8301b65c8d997f59049e7d
Author: Rob Paveza <ro...@microsoft.com>
Date: 2015-03-18T18:06:24Z
CB-8703: Test failure after merge to head.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-83149842
I think our review indicated that we couldn't yet officially deprecate Windows 8, and even if we could it would require the six month window.
The reason to rename target to deviceTarget was for consistency.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-86237288
LGTM, can I accept this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-85626756
I am okay with setting aside the deprecation discussion.
Does the renaming of target->deviceTarget have any impact outside this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-85617372
@purplecabbage Can we set aside the issue of the Windows 8 deprecation for this PR? There are still reasons we'll want to target package.appxmanifest with semver support anyway, Windows 8 or no. Any chance we can get this PR moved along? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-86999644
@purplecabbage. Yes, this one's ready to go! Please help commit this one and close this PR! :bow:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-87097870
Thanks, @purplecabbage ! There is a corresponding update to docs here that needs someone to commit it: https://github.com/apache/cordova-docs/pull/270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-83217204
Jesse - we couldn't use `target` for `<config-file>`, because there was already a `target` attribute that had a different meaning. So it was decided to go with `device-target`. I requested Rob change the equivalent `target` attribute on `<framework>` and `<lib-file>` so that it was consistent across elements.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by robpaveza <gi...@git.apache.org>.
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-85706497
Re: target->deviceTarget: No, all the tests pass, etc. Since I already did the merge/rebase, I can't really back out the change, but I'll definitely keep things like that in a separate commit in future PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-87065126
This is merged into master, not sure why the pull-request didn't close.
Please review master and close. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
RE: [GitHub] cordova-lib pull request: CB-8703: Add support for
semver and devi...
Posted by Tim Barham <Ti...@microsoft.com>.
Jesse - we couldn't use `target` for `<config-file>`, because there was already a `target` attribute that had a different meaning. So it was decided to go with `device-target`. I requested Rob change the equivalent `target` attribute on `<framework>` and `<lib-file>` so that it was consistent across elements.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/187#issuecomment-83118192
Personally I would much rather just drop support for Windows8 and move to an 8.1 universal only world ... then we can drop some of this wasted complexity.
Also, was there a specific need to rename target->deviceTarget ? this makes the pull request harder to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org