You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/04/11 00:48:43 UTC
[GitHub] [helix] pkuwm opened a new pull request #948: Add integration test
for Helix Java APIs using different MSDS endpoints
pkuwm opened a new pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Implements #947
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
- What
Metadatastore directory service(MSDS) provides routing functionality for requests to multi realm zookeeper servers. Java APIs talks to MSDS to fetch routing data when they are constructed.
- Why
To make sure Helix Java API is connecting to the correct MSDS endpoint, we would like to add an integration test. This test verifies that each API only connects to the configured MSDS endpoint but not other endpoints.
- How
1. Create 2 MSDS servers;
2. Create 2 instances of each Helix Java APIs: one is constructed with MSDS endpoint configured in system property, the other one is constructed with a RealmAwareZkConnectionConfig that has MSDS endpoint configured.
3. The Java API instances should only talk to its configured MSDS. Check the thrown exception when the instance is talking to an incorrect MSDS.
### Tests
- [ ] The following tests are written for this issue:
TestMultiZkHelixJavaApis.testDifferentMsdsEndpointConfigs
- [ ] The following is the result of the "mvn test" command on the appropriate module:
running...
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation (Optional)
- [ ] In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #948: Add
integration test for Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#discussion_r407022804
##########
File path: helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java
##########
@@ -89,6 +94,11 @@
private static final List<String> CLUSTER_LIST =
ImmutableList.of("CLUSTER_1", "CLUSTER_2", "CLUSTER_3");
+ // For testing different MSDS endpoint configs.
+ private static final String CLUSTER_THREE = "CLUSTER_3";
+ private static final String CLUSTER_FOUR = "CLUSTER_4";
+ private static final String SLASH = "/";
Review comment:
Or call it ROOT would be easier to understand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on issue #948: Add integration test for
Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#issuecomment-613136922
This PR is ready to be merged, approved by @narendly
```
To make sure Helix Java API is connecting to the correct MSDS endpoint, we would like to add an integration test. This test verifies that each API only connects to the configured MSDS endpoint but not other endpoints.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on a change in pull request #948: Add
integration test for Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
pkuwm commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#discussion_r407037079
##########
File path: helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java
##########
@@ -89,6 +94,11 @@
private static final List<String> CLUSTER_LIST =
ImmutableList.of("CLUSTER_1", "CLUSTER_2", "CLUSTER_3");
+ // For testing different MSDS endpoint configs.
+ private static final String CLUSTER_THREE = "CLUSTER_3";
+ private static final String CLUSTER_FOUR = "CLUSTER_4";
+ private static final String SLASH = "/";
Review comment:
- My initial thought was there are too many places that use slash so just wanted to make it a constant to reduce objects created.
- `PropertyPathBuilder` doesn't cover all the cases/paths creation in this test
- Slash does not only act as a root, but also a separator. So root does not satisfy very well.
- Instead, I just leave the way slash is used as it is in the original code, but create a `formPath()` for my case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly merged pull request #948: Add integration test for
Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
narendly merged pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #948: Add
integration test for Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#discussion_r407022391
##########
File path: helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java
##########
@@ -89,6 +94,11 @@
private static final List<String> CLUSTER_LIST =
ImmutableList.of("CLUSTER_1", "CLUSTER_2", "CLUSTER_3");
+ // For testing different MSDS endpoint configs.
+ private static final String CLUSTER_THREE = "CLUSTER_3";
+ private static final String CLUSTER_FOUR = "CLUSTER_4";
+ private static final String SLASH = "/";
Review comment:
Why? Consider using PropertyPathBuilder to avoid hard code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] jiajunwang commented on a change in pull request #948: Add
integration test for Helix Java APIs using different MSDS endpoints
Posted by GitBox <gi...@apache.org>.
jiajunwang commented on a change in pull request #948: Add integration test for Helix Java APIs using different MSDS endpoints
URL: https://github.com/apache/helix/pull/948#discussion_r407024270
##########
File path: helix-core/src/test/java/org/apache/helix/integration/multizk/TestMultiZkHelixJavaApis.java
##########
@@ -89,6 +94,11 @@
private static final List<String> CLUSTER_LIST =
ImmutableList.of("CLUSTER_1", "CLUSTER_2", "CLUSTER_3");
Review comment:
Two "CLUSTER_3"s are defined separately. Not cool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org