You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2008/05/20 17:50:05 UTC
svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: remm
Date: Tue May 20 08:50:05 2008
New Revision: 658292
URL: http://svn.apache.org/viewvc?rev=658292&view=rev
Log:
- Votes.
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=658292&r1=658291&r2=658292&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 20 08:50:05 2008
@@ -77,15 +77,12 @@
Note: This is on the critical path
http://svn.apache.org/viewvc?rev=657954&view=rev
+1: markt
- -1: remm (the library causing this bug cannot possibly have read the little
- hidden, optional appendix from the HTTP/1.0 spec, and rely on it, so it is simply broken;
- it may not apply to HTTP/1.1, which may be more strict; passing full URLs in the
- request line is normally an HTTP/1.1 thing, from what I remember, usable as an alternative
- to the mandatory Host header)
+ -1:
markt Both the HTTP/1.1 and HTTP/1.0 contain broadly the same text
regarding tolerant applications. (ie allow multiple SP/HT between
method-url and url-httpVersion). However, it is optional so we don't
have to support it.
+ remm Apparently httpd does that, so I am changing my vote to "ignore issue"
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
Use any META-INF/context.xml in a consistent manner and ensure it is used on
@@ -95,4 +92,6 @@
-1: remm (would need convincing that this is really well tested, otherwise delay to next release)
markt Exactly what would convince you that this was well tested above and
beyond the local testing that I have done to convince myself that
- this patch does what I want it to.
\ No newline at end of file
+ this patch does what I want it to.
+ remm I am not sure this was fully tested. For example, the order of redeployResources is
+ likely significant, and it is changed in deployDirectory
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Remy Maucherat wrote:
> On Thu, 2008-05-22 at 18:43 +0100, Mark Thomas wrote:
>> I spent some time looking at this code and I think I understand it better
>> than I did when I wrote the patch and enough to agree that my patch will
>> break things. I'll pull this patch and look at it some more. I have this
>> nagging feeling it could all be simpler but I can't quite see how just yet.
>
> If you could write a simpler auto deployer it would be nice. Do you
> agree with keeping this for next release ?
I'm holding off on forming a final opinion until I see how complex the
patch is. Simple -> this release, complex -> next release, somewhere in the
middle -> propose it and see how people vote.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Remy Maucherat <re...@apache.org>.
On Thu, 2008-05-22 at 18:43 +0100, Mark Thomas wrote:
> I spent some time looking at this code and I think I understand it better
> than I did when I wrote the patch and enough to agree that my patch will
> break things. I'll pull this patch and look at it some more. I have this
> nagging feeling it could all be simpler but I can't quite see how just yet.
If you could write a simpler auto deployer it would be nice. Do you
agree with keeping this for next release ?
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Remy Maucherat wrote:
> On Wed, 2008-05-21 at 00:16 +0100, Mark Thomas wrote:
>> remm@apache.org wrote:
>>> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
>>> Use any META-INF/context.xml in a consistent manner and ensure it is used on
>>> @@ -95,4 +92,6 @@
>>> -1: remm (would need convincing that this is really well tested, otherwise delay to next release)
>>> markt Exactly what would convince you that this was well tested above and
>>> beyond the local testing that I have done to convince myself that
>>> - this patch does what I want it to.
>>> \ No newline at end of file
>>> + this patch does what I want it to.
>>> + remm I am not sure this was fully tested. For example, the order of redeployResources is
>>> + likely significant, and it is changed in deployDirectory
>>> \ No newline at end of file
>> You'd think the order mattered since someone went to the bother of
>> specifying a LinkedHashMap but I didn't see anything in checkResources() -
>> the only place the data is read - that depended on order. Do you see
>> something I don't?
>
> That someone who used a LinkedHashMap was me, and the order should be
> significant (after checking, some operations are done on the rest of the
> list, like: for (int j = i + 1; j < resources.length; j++)).
I spent some time looking at this code and I think I understand it better
than I did when I wrote the patch and enough to agree that my patch will
break things. I'll pull this patch and look at it some more. I have this
nagging feeling it could all be simpler but I can't quite see how just yet.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Remy Maucherat <re...@apache.org>.
On Wed, 2008-05-21 at 00:16 +0100, Mark Thomas wrote:
> remm@apache.org wrote:
> > * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
> > Use any META-INF/context.xml in a consistent manner and ensure it is used on
> > @@ -95,4 +92,6 @@
> > -1: remm (would need convincing that this is really well tested, otherwise delay to next release)
> > markt Exactly what would convince you that this was well tested above and
> > beyond the local testing that I have done to convince myself that
> > - this patch does what I want it to.
> > \ No newline at end of file
> > + this patch does what I want it to.
> > + remm I am not sure this was fully tested. For example, the order of redeployResources is
> > + likely significant, and it is changed in deployDirectory
> > \ No newline at end of file
>
> You'd think the order mattered since someone went to the bother of
> specifying a LinkedHashMap but I didn't see anything in checkResources() -
> the only place the data is read - that depended on order. Do you see
> something I don't?
That someone who used a LinkedHashMap was me, and the order should be
significant (after checking, some operations are done on the rest of the
list, like: for (int j = i + 1; j < resources.length; j++)).
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658292 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
remm@apache.org wrote:
> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
> Use any META-INF/context.xml in a consistent manner and ensure it is used on
> @@ -95,4 +92,6 @@
> -1: remm (would need convincing that this is really well tested, otherwise delay to next release)
> markt Exactly what would convince you that this was well tested above and
> beyond the local testing that I have done to convince myself that
> - this patch does what I want it to.
> \ No newline at end of file
> + this patch does what I want it to.
> + remm I am not sure this was fully tested. For example, the order of redeployResources is
> + likely significant, and it is changed in deployDirectory
> \ No newline at end of file
You'd think the order mattered since someone went to the bother of
specifying a LinkedHashMap but I didn't see anything in checkResources() -
the only place the data is read - that depended on order. Do you see
something I don't?
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org