You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by an...@apache.org on 2019/11/05 15:04:04 UTC
svn commit: r1869391 - in /jackrabbit/oak/trunk/oak-auth-external: pom.xml
src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java
Author: angela
Date: Tue Nov 5 09:48:25 2019
New Revision: 1869391
URL: http://svn.apache.org/viewvc?rev=1869391&view=rev
Log:
OAK-8725 : Improve tests for oak-external-auth
Modified:
jackrabbit/oak/trunk/oak-auth-external/pom.xml
jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java
Modified: jackrabbit/oak/trunk/oak-auth-external/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/pom.xml?rev=1869391&r1=1869390&r2=1869391&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/pom.xml (original)
+++ jackrabbit/oak/trunk/oak-auth-external/pom.xml Tue Nov 5 09:48:25 2019
@@ -34,8 +34,8 @@
<properties>
<!-- enable execution of jacoco and set minimal line coverage -->
<skip.coverage>false</skip.coverage>
- <minimum.line.coverage>0.83</minimum.line.coverage>
- <minimum.branch.coverage>0.81</minimum.branch.coverage>
+ <minimum.line.coverage>0.96</minimum.line.coverage>
+ <minimum.branch.coverage>0.99</minimum.branch.coverage>
</properties>
<build>
Modified: jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java?rev=1869391&r1=1869390&r2=1869391&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java (original)
+++ jackrabbit/oak/trunk/oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalTest.java Tue Nov 5 09:48:25 2019
@@ -161,4 +161,30 @@ public class ExternalGroupPrincipalTest
assertTrue(gp instanceof GroupPrincipal);
assertFalse(((GroupPrincipal)gp).members().hasMoreElements());
}
+
+ @Test(expected = UnsupportedOperationException.class)
+ public void testAddNewMember() throws Exception {
+ java.security.acl.Group principal = (java.security.acl.Group) getGroupPrincipal();
+ principal.addMember(new PrincipalImpl("newMember"));
+ }
+
+ @Test
+ public void testAddExistingMember() throws Exception {
+ java.security.acl.Group principal = (java.security.acl.Group) getGroupPrincipal();
+ Principal existingMember = getUserManager(root).getAuthorizable(USER_ID).getPrincipal();
+ assertFalse(principal.addMember(existingMember));
+ }
+
+ @Test
+ public void testRemoveeNewMember() throws Exception {
+ java.security.acl.Group principal = (java.security.acl.Group) getGroupPrincipal();
+ assertFalse(principal.removeMember(new PrincipalImpl("newMember")));
+ }
+
+ @Test(expected = UnsupportedOperationException.class)
+ public void testRemoveExistingMember() throws Exception {
+ java.security.acl.Group principal = (java.security.acl.Group) getGroupPrincipal();
+ Principal existingMember = getUserManager(root).getAuthorizable(USER_ID).getPrincipal();
+ principal.removeMember(existingMember);
+ }
}