You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jobs@airflow.apache.org by GitBox <gi...@apache.org> on 2026/04/30 13:38:15 UTC
[GH] (airflow/ipc-trace-propagation): Workflow run "Tests" failed!
The GitHub Actions job "Tests" on airflow.git/ipc-trace-propagation has failed.
Run started by GitHub user ashb (triggered by ashb).
Head commit for run:
eb4783d9b34291398c1eb3f101f785861f3efdcc / Ash Berlin-Taylor <as...@apache.org>
Propagate task OTel trace context through IPC and into execution API requests
The supervisor makes HTTP calls (XCom pushes, RTIF writes, connection
lookups) on behalf of the task process via a Unix socket IPC channel.
Without explicit propagation, those calls either float under the
supervisor's own span or are unparented entirely — the task's trace
context never crosses the process boundary.
This commit wires the full chain:
IPC leg (task process → supervisor):
- Add traceparent: str | None = None field to _RequestFrame
- _make_frame() injects the task runner's active W3C traceparent into
every outgoing IPC frame via TraceContextTextMapPropagator.inject()
- handle_requests() extracts the traceparent and calls
otel_context.attach() before dispatching each request, restoring the
task's trace context in the supervisor process for that request's
lifetime
- TriggerCommsDecoder.asend() now calls _make_frame() instead of
constructing _RequestFrame directly, so trigger IPC frames carry
the active span's traceparent too
HTTP leg (supervisor → execution API):
- inject_trace_context event hook on the httpx Client propagates the
currently-active span's traceparent header on every outgoing request,
linking server-side spans to the correct task span
- _log_and_trace_retry records http.retry events on the active span
alongside the existing log warning
Dependency cleanup:
- Move opentelemetry-api>=1.27.0 from [otel] optional extras to base
[dependencies] in shared/observability — it flows unconditionally into
task-sdk via shared_distributions, the same way airflow-core already
has it unconditionally
- Replace try/except ImportError guards and _NoOpTracer fallbacks in
comms.py, supervisor.py, and client.py with direct imports; inject()
and get_current_span() are no-ops when no TracerProvider is configured,
so the guards were only testing "is OTel installed?" not "is it enabled?"
- Introduce _FrameMixin (plain Python mixin, not a msgspec.Struct) to
share _encoder and as_bytes() between _RequestFrame and _ResponseFrame
Report URL: https://github.com/apache/airflow/actions/runs/25165172025
With regards,
GitHub Actions via GitBox
---------------------------------------------------------------------
To unsubscribe, e-mail: jobs-unsubscribe@airflow.apache.org
For additional commands, e-mail: jobs-help@airflow.apache.org