You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/24 20:50:29 UTC

[GitHub] [arrow] westonpace opened a new pull request #12710: [C++] arrow-compute-hash-join-node-test timeout on MinGW

westonpace opened a new pull request #12710:
URL: https://github.com/apache/arrow/pull/12710


   It's possible there is an actual deadlock but right now the passing jobs are anywhere in the range of 240-260 for this test and so I think it's also possible that a busy CI node might just be taking 300+ seconds.  This change should shorten the runtime of this test considerably, hopefully without sacrificing the randomness we are testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] westonpace commented on pull request #12710: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078264994


   CC @michalursa who advised on some of these changes.  Can you please take a look?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12710: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078264382


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Buildkite builds:
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/374| `62dfa4a3` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/360| `62dfa4a3` test-mac-arm>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/352| `62dfa4a3` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/370| `62dfa4a3` ursa-thinkcentre-m75q>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/372| `51f837f7` ec2-t3-xlarge-us-east-2>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/359| `51f837f7` test-mac-arm>
   [Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/351| `51f837f7` ursa-i9-9960x>
   [Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/369| `51f837f7` ursa-thinkcentre-m75q>
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078266729






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Failed] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12710:
URL: https://github.com/apache/arrow/pull/12710#issuecomment-1078562847


   Benchmark runs are scheduled for baseline = 51f837f7ccce547a8a8574dd783531fb0be792e8 and contender = 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f. 62dfa4a3d1bcd5a4538fc62862d26ee6219bed7f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/0fa9a2cd2e334a4f8325c85d1e2b3ca7...47acf8e09a0246c699bd7ee40df6bdc6/)
   [Finished :arrow_down:0.21% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/13d3d857fe804404a7fe65f4d58c7c16...1f826db323254c4f86c5e3ddeb355f2c/)
   [Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/665d58d025674bda8252becea5cd45d8...65074194afab4aa79aa2918d09fe3bcf/)
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/ea2a5395f1b3490382bad8711fc6e48f...8bbe71ee7abf4c37b94de660d28254bf/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] westonpace closed pull request #12710: ARROW-16021: [C++] arrow-compute-hash-join-node-test timeout on MinGW

Posted by GitBox <gi...@apache.org>.
westonpace closed pull request #12710:
URL: https://github.com/apache/arrow/pull/12710


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org