You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/18 00:11:22 UTC

[GitHub] [incubator-mxnet] DickJC123 opened a new pull request #19173: [v1.x] Backport Improve environment variable handling in unittests (#18424)

DickJC123 opened a new pull request #19173:
URL: https://github.com/apache/incubator-mxnet/pull/19173


   ## Description ##
   This is a backport to v1.x of the PR https://github.com/apache/incubator-mxnet/pull/18424.  The original PR built on the work of @larroy, and introduced the `with environment():` context and `@with_environment()` decorator.  The PR replaced the ad hoc manipulation of environment variables in unittests and solved the 'read-only env var state' problem of Windows.
   
   ## Checklist ##
   ### Essentials ###
   - [X] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage
   - [X] Code is well-documented
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] leezu merged pull request #19173: [v1.x] Backport Improve environment variable handling in unittests (#18424)

Posted by GitBox <gi...@apache.org>.
leezu merged pull request #19173:
URL: https://github.com/apache/incubator-mxnet/pull/19173


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19173: [v1.x] Backport Improve environment variable handling in unittests (#18424)

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19173:
URL: https://github.com/apache/incubator-mxnet/pull/19173#issuecomment-694567637


   Hey @DickJC123 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, unix-cpu, clang, sanity, unix-gpu, edge, miscellaneous, windows-gpu, centos-gpu, website, centos-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org