You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/23 09:32:17 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #18461: remove redundant css state colors
bbovenzi opened a new pull request #18461:
URL: https://github.com/apache/airflow/pull/18461
The true source of truth for state colors somes from `settings.py` and is exposed to the frontend through the webserver. The css state colors are redundant and cause confusion on the source of truth. Really, they are left over from when colors were not defined by `settings.py` (going back to the first airflow commit).
Also, cleaned up some indentation for making the legends in the tree and graph html files
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #18461: remove redundant css state colors
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #18461:
URL: https://github.com/apache/airflow/pull/18461#issuecomment-925755511
This is great. I've been wanting to clean this up forever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #18461: remove redundant css state colors
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #18461:
URL: https://github.com/apache/airflow/pull/18461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18461: remove redundant css state colors
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18461:
URL: https://github.com/apache/airflow/pull/18461#issuecomment-925683176
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on pull request #18461: remove redundant css state colors
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on pull request #18461:
URL: https://github.com/apache/airflow/pull/18461#issuecomment-925812344
@bbovenzi I forgot we also output these classes globally in the document `<head>` here:
https://github.com/apache/airflow/blob/2a3cbabbf8a21123e0b9c35866226087c3cebc4c/airflow/www/templates/airflow/main.html#L41-L47
Might be ideal to replace it with CSS variable definitions and then key everything else off of those?
```jinja
<style type="text/css">
:root {
{% for state, state_color in state_color_mapping.items() %}
--status-color-{{state}}: {{state_color}};
{% endfor %}
}
</style>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi closed pull request #18461: remove redundant css state colors
Posted by GitBox <gi...@apache.org>.
bbovenzi closed pull request #18461:
URL: https://github.com/apache/airflow/pull/18461
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org