You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/11/18 22:34:06 UTC

[GitHub] [tvm] naut-thomas opened a new pull request, #13439: [RPC] Catch potential race-condition exception on termination

naut-thomas opened a new pull request, #13439:
URL: https://github.com/apache/tvm/pull/13439

   Observed a race condition on Hexagon where the rpc_key got removed from the scheduler map and thus wasn't in the remove loop anymore and throwing a KeyError. A simple try-except on the first try makes sure it is still there before removal (if we still have to).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] tvm-bot commented on pull request #13439: [RPC] Catch potential race-condition exception on termination

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13439:
URL: https://github.com/apache/tvm/pull/13439#issuecomment-1320604315

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * No users to tag found in teams: `rpc` <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] naut-thomas commented on pull request #13439: [RPC] Catch potential race-condition exception on termination

Posted by GitBox <gi...@apache.org>.
naut-thomas commented on PR #13439:
URL: https://github.com/apache/tvm/pull/13439#issuecomment-1320604870

   @Lunderberg @areusch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] areusch commented on pull request #13439: [RPC] Catch potential race-condition exception on termination

Posted by GitBox <gi...@apache.org>.
areusch commented on PR #13439:
URL: https://github.com/apache/tvm/pull/13439#issuecomment-1322632546

   thanks @naut-thomas, can you confirm whether `__del__` is executing when the stacktrace is raised?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org