You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "me2seeks (via GitHub)" <gi...@apache.org> on 2026/10/01 17:14:42 UTC

[PR] feat(cli): bind Tab and Shift+Left for TUI queue and retract [maka]

me2seeks opened a new pull request, #5910:
URL: https://github.com/apache/maka/pull/5910

   ## Summary
   
   The TUI's queue (`Alt+Enter`) and retract (`Alt+↑`) chords are intercepted by Windows Terminal and never reach the app on macOS Terminal/iTerm, so both turn-control actions are unavailable on those terminals. This adds the macOS/Windows-safe pair Codex ships for the same actions, keeping the Alt chords as aliases:
   
   - **`Tab` — queue a followup for the next turn** (while a turn runs). Intercepted only with a non-empty draft, no completion popup open, and no paste in flight, so the editor keeps owning Tab for completion and idle input is untouched.
   - **`Shift+←` — retract queued messages back into the editor.** Not an editor binding, so it consumes unconditionally with the same rationale as `Alt+↑` (an empty retract refill is a no-op).
   
   Delivery semantics are unchanged: both keys route through the existing `queueOrSubmit` / `retractQueuedMessages` paths and the same `turn.message.submit` / `queue.retract` operations. `/help` and the pending-bar hint now name both routes in en, zh-CN, and zh-TW.
   
   Refs #3538
   
   ## Verification
   
   - `node --test dist/__tests__/pi-tui-runner.test.js` — 226/226 pass, including three new tests: Tab queues a followup during a turn (same as Alt+Enter), idle Tab stays with the editor and does not submit, Shift+Left retracts queued messages into the editor.
   - `biome lint` and `biome format` clean on the three touched files.
   - `tsc -p packages/cli/tsconfig.json --noEmit` clean.
   - Not run: manual terminal testing on macOS/Windows (no access from this environment); the new sequences (`\t`, `\x1b[d` / `\x1b[1;2D`) are standard and pi-tui already decodes both Shift+Left forms.
   
   ## AI use
   
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Maka — investigated the input routing, drafted the implementation, tests, and localized copy; commits carry `Generated-by` trailers.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] feat(cli): replace Alt chords with Tab and Shift+Left for TUI queue and retract [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks commented on PR #5910:
URL: https://github.com/apache/maka/pull/5910#issuecomment-5946423433

   Both failures addressed in 3ff6df32c4 (pushed just now):
   
   - `keeps keybinding tokens identical across locales` — the tokens are now `Tab` and `Shift+←` in all three locales, so the deep-equal holds again.
   - `renders the pending-queue edit shortcut for the current platform` — updated to the new reality: with no Alt token in the hint there is nothing left for the platform rewriting, so darwin and linux render identically; the test now asserts exactly that.
   
   This revision also drops the Alt chords entirely instead of keeping them as aliases (per issue author decision — on macOS/Windows terminals they conflict rather than merely being awkward), which is what removed the cross-locale token mismatch at the root rather than patching around it.
   
   Local: pi-tui-runner 224/224, pi-transcript + tui-primary-guidance + tui-copy-command + tui-shortcut-copy 131/131, biome lint/format and tsc clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] feat(cli): replace Alt chords with Tab and Shift+Left for TUI queue and retract [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5910:
URL: https://github.com/apache/maka/pull/5910


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org