You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "zhuqi-lucas (via GitHub)" <gi...@apache.org> on 2023/05/05 15:14:34 UTC
[GitHub] [yunikorn-core] zhuqi-lucas opened a new pull request, #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
zhuqi-lucas opened a new pull request, #540:
URL: https://github.com/apache/yunikorn-core/pull/540
### What is this PR for?
See my latest comments in https://issues.apache.org/jira/browse/YUNIKORN-1712.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1712
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. `[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] zhuqi-lucas commented on pull request #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #540:
URL: https://github.com/apache/yunikorn-core/pull/540#issuecomment-1536410770
Hi @wilfred-s @craigcondit , could you help review this PR.
See my latest comments in https://issues.apache.org/jira/browse/YUNIKORN-1712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
Posted by "craigcondit (via GitHub)" <gi...@apache.org>.
craigcondit closed pull request #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
URL: https://github.com/apache/yunikorn-core/pull/540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] zhuqi-lucas commented on pull request #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
Posted by "zhuqi-lucas (via GitHub)" <gi...@apache.org>.
zhuqi-lucas commented on PR #540:
URL: https://github.com/apache/yunikorn-core/pull/540#issuecomment-1543258606
Thank you @wilfred-s and @craigcondit for review, added unit test now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #540: [YUNIKORN-1712] Fix allocatedResource and availableResource should be updated at the sametime for ReplaceAllocation
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #540:
URL: https://github.com/apache/yunikorn-core/pull/540#issuecomment-1536418396
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-core/pull/540?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#540](https://app.codecov.io/gh/apache/yunikorn-core/pull/540?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (797d13b) into [master](https://app.codecov.io/gh/apache/yunikorn-core/commit/8664ce2b584c41fbfe3ea4aa41634d48214295d0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8664ce2) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #540 +/- ##
=======================================
Coverage 75.06% 75.06%
=======================================
Files 70 70
Lines 11332 11334 +2
=======================================
+ Hits 8506 8508 +2
Misses 2529 2529
Partials 297 297
```
| [Impacted Files](https://app.codecov.io/gh/apache/yunikorn-core/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/node.go](https://app.codecov.io/gh/apache/yunikorn-core/pull/540?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL25vZGUuZ28=) | `82.02% <100.00%> (+0.10%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org